Skip to content

fix(plugin-oracle): Switch to ALL_TAB_* as DBA_TAB* requires ADMIN pe… #26554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(plugin-oracle): Switch to ALL_TAB_* as DBA_TAB* requires ADMIN pe… #26554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions presto-oracle/src/main/java/com/facebook/presto/plugin/oracle/OracleClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public TableStatistics getTableStatistics(ConnectorSession session, JdbcTableHan
requireNonNull(handle.getTableName(), "table name is null");
String sql = format(
"SELECT NUM_ROWS, AVG_ROW_LEN, LAST_ANALYZED\n" +
"FROM DBA_TAB_STATISTICS\n" +
"FROM ALL_TAB_STATISTICS\n" +
"WHERE OWNER='%s'\n" +
"AND TABLE_NAME='%s'",
handle.getSchemaName().toUpperCase(), handle.getTableName().toUpperCase());
Expand Down Expand Up @@ -190,9 +190,12 @@ public TableStatistics getTableStatistics(ConnectorSession session, JdbcTableHan
double lowValue = toDouble(resultSetColumnStats.getString("LOW_VALUE"));
double highValue = toDouble(resultSetColumnStats.getString("HIGH_VALUE"));
ColumnStatistics.Builder columnStatisticsBuilder = ColumnStatistics.builder()
.setDataSize(Estimate.estimateFromDouble(resultSet.getDouble("DATA_LENGTH")))
.setNullsFraction(Estimate.estimateFromDouble(nullsCount / numRows))
.setDistinctValuesCount(Estimate.estimateFromDouble(ndv));
if (resultSetColumnStats.getString("DATA_TYPE").startsWith("VARCHAR") ||
resultSetColumnStats.getString("DATA_TYPE").startsWith("CHAR")) {
columnStatisticsBuilder.setDataSize(Estimate.estimateFromDouble(resultSetColumnStats.getDouble("DATA_LENGTH")));
}
ColumnStatistics columnStatistics = columnStatisticsBuilder.build();
if (Double.isFinite(lowValue) && Double.isFinite(highValue)) {
columnStatistics = columnStatisticsBuilder.setRange(new DoubleRange(lowValue, highValue)).build();
Expand Down
Loading