-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: Added spillBaseDir for PartitionAndSerializeReplayer #26562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary: Added spillBaseDir for PartitionAndSerializeReplayer ``` == NO RELEASE NOTE == ``` Differential Revision: D86552256
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR introduces a new spillBaseDir parameter to the PartitionAndSerializeReplayer, updating its constructor signature, propagating the argument through the implementation, and adjusting all call sites to include a placeholder value. Class diagram for updated PartitionAndSerializeReplayer constructorclassDiagram
class PartitionAndSerializeReplayer {
+PartitionAndSerializeReplayer(
const std::string& taskId,
const std::string& nodeId,
const std::string& nodeName,
const std::string& spillBaseDir,
const std::string& driverIds,
uint64_t queryCapacity,
folly::Executor* executor
)
}
PartitionAndSerializeReplayer --|> OperatorReplayerBase
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Expose spillBaseDir via a CLI flag in TraceReplayerMain instead of hardcoding an empty string
- Add a test case that uses a non-empty spillBaseDir to verify the new parameter is correctly propagated
- Restore or align the removed copyright/license headers with the project style guidelines
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Expose spillBaseDir via a CLI flag in TraceReplayerMain instead of hardcoding an empty string
- Add a test case that uses a non-empty spillBaseDir to verify the new parameter is correctly propagated
- Restore or align the removed copyright/license headers with the project style guidelinesHelp me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary:
Added spillBaseDir for PartitionAndSerializeReplayer
Differential Revision: D86552256