Skip to content

fix: Added spillBaseDir for PartitionAndSerializeReplayer #26562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −8
Open

fix: Added spillBaseDir for PartitionAndSerializeReplayer #26562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions presto-native-execution/presto_cpp/main/tool/trace/PartitionAndSerializeReplayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/*
* Copyright (c) Facebook, Inc. and its affiliates.
*/
#include "presto_cpp/main/tool/trace/PartitionAndSerializeReplayer.h"

#include "presto_cpp/main/operators/PartitionAndSerialize.h"
#include "velox/tool/trace/TraceReplayTaskRunner.h"

Expand All @@ -32,6 +28,7 @@ PartitionAndSerializeReplayer::PartitionAndSerializeReplayer(
const std::string& taskId,
const std::string& nodeId,
const std::string& nodeName,
const std::string& spillBaseDir,
const std::string& driverIds,
uint64_t queryCapacity,
folly::Executor* executor)
Expand All @@ -41,6 +38,7 @@ PartitionAndSerializeReplayer::PartitionAndSerializeReplayer(
taskId,
nodeId,
nodeName,
spillBaseDir,
driverIds,
queryCapacity,
executor) {}
Expand Down
5 changes: 1 addition & 4 deletions presto-native-execution/presto_cpp/main/tool/trace/PartitionAndSerializeReplayer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,12 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/*
* Copyright (c) Facebook, Inc. and its affiliates.
*/
#pragma once

#include "velox/core/PlanNode.h"
#include "velox/tool/trace/OperatorReplayerBase.h"

namespace facebook::velox::tool::trace {

/// The replayer to replay the traced 'PartitionAndSerialize' operators.
class PartitionAndSerializeReplayer final : public OperatorReplayerBase {
public:
Expand All @@ -30,6 +26,7 @@ class PartitionAndSerializeReplayer final : public OperatorReplayerBase {
const std::string& taskId,
const std::string& nodeId,
const std::string& nodeName,
const std::string& spillBaseDir,
const std::string& driverIds,
uint64_t queryCapacity,
folly::Executor* executor);
Expand Down
1 change: 1 addition & 0 deletions presto-native-execution/presto_cpp/main/tool/trace/TraceReplayerMain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ class PrestoTraceReplayRunner
FLAGS_task_id,
FLAGS_node_id,
nodeName,
"",
FLAGS_driver_ids,
queryCapacityBytes,
cpuExecutor_.get());
Expand Down
1 change: 1 addition & 0 deletions ...o-native-execution/presto_cpp/main/tool/trace/tests/PartitionAndSerializeReplayerTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ TEST_F(PartitionAndSerializeReplayerTest, basicReplay) {
task->taskId(),
partitionNodeId,
"PartitionAndSerialize",
"",
driverIds,
queryCapacity,
executor_.get());
Expand Down
Loading