Skip to content

Conversation

@unidevel
Copy link
Contributor

@unidevel unidevel commented Jan 23, 2026

Description

Add tests for released docker images, to avoid issue like #26996 for future changes about release actions.

This PR requires prestodb/presto-release-tools#61 merge first.

Motivation and Context

#27004

Impact

Release

Test Plan

https://github.com/unix280/presto/actions/runs/21278995747

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 23, 2026
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 23, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a new GitHub Actions job to run tests against the published Presto native Docker image as part of the release workflow, ensuring the released image for the specified version tag is validated after publication.

Sequence diagram for invoking Docker image tests in release workflow

sequenceDiagram
    participant GH_Actions as GitHub_Actions
    participant PublishNative as publish-native-image_job
    participant NativeTests as native-image-tests_job
    participant ReusableWF as presto-release-tools_docker-image-tests_workflow
    participant DockerRegistry as Docker_Registry

    GH_Actions->>PublishNative: Run job publish-native-image
    PublishNative->>DockerRegistry: Push native image with tag RELEASE_VERSION
    PublishNative-->>GH_Actions: Job completed successfully

    GH_Actions->>NativeTests: Start job native-image-tests
    NativeTests->>ReusableWF: Call workflow docker-image-tests.yml
    Note over NativeTests,ReusableWF: with input image_tag = RELEASE_VERSION
    ReusableWF->>DockerRegistry: Pull image with tag RELEASE_VERSION
    ReusableWF->>ReusableWF: Run Docker image tests
    ReusableWF-->>NativeTests: Report test results
    NativeTests-->>GH_Actions: Mark job success/failure
Loading

File-Level Changes

Change Details Files
Introduce a post-publish CI job that runs tests against the released native Docker image for the specified release version.
  • Add a native-image-tests job that depends on the publish-native-image job in the release workflow.
  • Configure the job to run only when the workflow has not failed or been cancelled.
  • Reuse the docker-image-tests reusable workflow from the presto-release-tools repository.
  • Pass the release version input as the image_tag parameter to the reusable Docker image tests workflow.
.github/workflows/presto-release-publish.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants