Skip to content

Conversation

@Ishaan-2312
Copy link

@Ishaan-2312 Ishaan-2312 commented Jan 27, 2026

Description

Earlier the Iceberg connector did not get linked to a valid page, and this change fixes the issue by correctly mapping it to the Iceberg connector documentation page.

Motivation and Context

The previous documentation link for the Iceberg connector was invalid, which could confuse users trying to navigate to the correct connector documentation. This change ensures the link points to the correct and valid page.

Impact

Documentation-only change. No public API, user-facing behavior, or performance impact.

Test Plan

Verified the updated link points to the correct Iceberg connector documentation page.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

 == NO RELEASE NOTE == 

@Ishaan-2312 Ishaan-2312 requested review from a team, elharo and steveburnett as code owners January 27, 2026 21:23
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 27, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the ANALYZE SQL documentation to reference the correct Iceberg connector, fixing an outdated or incorrect connector name in the docs.

File-Level Changes

Change Details Files
Correct Iceberg connector reference in ANALYZE command documentation.
  • Update the connector name or reference in the ANALYZE section to point to the Iceberg connector instead of an incorrect/old connector
  • Ensure surrounding text remains consistent with existing documentation style and terminology
presto-docs/src/main/sphinx/sql/analyze.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `presto-docs/src/main/sphinx/sql/analyze.rst:23-25` </location>
<code_context>

 Currently, this statement is only supported by the
-:ref:`Hive connector <hive_analyze>`.
+:ref:`Hive connector <hive_analyze>` and
+:doc:`Iceberg connector <../connector/iceberg>`.

 Examples
</code_context>

<issue_to_address>
**suggestion (typo):** Consider adding "the" before "Iceberg connector" for parallel structure.

This will keep the phrasing grammatically consistent with the existing "the Hive connector" reference.

```suggestion
Currently, this statement is only supported by the
:ref:`Hive connector <hive_analyze>` and
:doc:`the Iceberg connector <../connector/iceberg>`.
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines 23 to +25
Currently, this statement is only supported by the
:ref:`Hive connector <hive_analyze>`.
:ref:`Hive connector <hive_analyze>` and
:doc:`Iceberg connector <../connector/iceberg>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (typo): Consider adding "the" before "Iceberg connector" for parallel structure.

This will keep the phrasing grammatically consistent with the existing "the Hive connector" reference.

Suggested change
Currently, this statement is only supported by the
:ref:`Hive connector <hive_analyze>`.
:ref:`Hive connector <hive_analyze>` and
:doc:`Iceberg connector <../connector/iceberg>`.
Currently, this statement is only supported by the
:ref:`Hive connector <hive_analyze>` and
:doc:`the Iceberg connector <../connector/iceberg>`.

@github-actions github-actions bot added the docs label Jan 27, 2026
@github-project-automation github-project-automation bot moved this to 🆕 Unprioritized in Presto Documentation Jan 27, 2026
@tdcmeehan tdcmeehan changed the title Fix Iceberg connector reference in ANALYZE docs fix(docs): Iceberg connector reference in ANALYZE docs Jan 27, 2026
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an example to the Iceberg connector doc that parallels the linked doc in the Hive connector.

@steveburnett
Copy link
Contributor

Please edit the PR Description to set the release note as

== NO RELEASE NOTE ==

(including the row of three (`) above and below the text to format it as code)

to pass the (not required to merge) failing test.

@Ishaan-2312
Copy link
Author

Hi, quick question — is there a specific place in the Iceberg connector docs or code where the supported ANALYZE syntax/properties are documented?
I want to make sure the example I add for the Iceberg connector matches the intended/official usage.

@hantangwangd
Copy link
Member

@Ishaan-2312 actually, Iceberg only supports table-level statistics analyzing and does not support table properties like partitions or configurations for quick stats, as Hive does.

To confirm this, you can refer to the Hive Connector's implementation of getAnalyzeProperties method, as well as the configuration related to quick stats in HiveClientConfig/HiveSessionProperties. Currently, there are no equivalent configurations in Iceberg.

@steveburnett
Copy link
Contributor

@Ishaan-2312 actually, Iceberg only supports table-level statistics analyzing and does not support table properties like partitions or configurations for quick stats, as Hive does.

To confirm this, you can refer to the Hive Connector's implementation of getAnalyzeProperties method, as well as the configuration related to quick stats in HiveClientConfig/HiveSessionProperties. Currently, there are no equivalent configurations in Iceberg.

@hantangwangd, are you saying that we don't need an example in the Iceberg doc similar to the example linked to in the Hive doc? If that is what you mean, then I am okay with this PR as it is now and I'm willing to approve it.

@hantangwangd
Copy link
Member

@steveburnett no, I was just responding to @Ishaan-2312's question. I thought that he wanted to confirm the exact usage of ANALYZE in the Iceberg connector. I also agree with your point — we'd better add a section in the Iceberg connector doc similar to the one in the linked doc in the Hive connector. This would be helpful considering we may later introduce partition-level ANALYZE supports as well. @Ishaan-2312 what's your opinion?

@Ishaan-2312
Copy link
Author

Yeah I definitely think there should be a section in the iceberg connector doc for the working of the ANALYZE section and if you both @steveburnett and @hantangwangd also agree with this then I would be willing to do that work in the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🆕 Unprioritized

Development

Successfully merging this pull request may close these issues.

3 participants