test: Add Sequence and Exclude columns function tests with lateral

[mohsaka]

Description

Add examples for lateral calls with table function calls.

Motivation and Context

Add more test coverage and show examples.

Impact

Test Plan

Ran ExcludeColumns and Sequence tests to verify they pass.

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.
• If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

Summary by Sourcery

Add test coverage for using table functions in lateral joins.

Tests:

• Add an exclude_columns lateral join test validating filtered results against a standard join.
• Add a sequence lateral join test comparing table function output with UNNEST(sequence(...)).

[sourcery-ai]

Reviewer's Guide

Adds new test coverage demonstrating use of the exclude_columns table function and the sequence table function within LATERAL joins, validating behavior under filtering and join conditions against TPCH tables.

File-Level Changes

Change	Details	Files
Add LATERAL join coverage for exclude_columns table function.	Introduce testExcludeColumnsLateralJoin to assert behavior of system.builtin.exclude_columns when used via TABLE() in a CROSS JOIN LATERAL subquery with a WHERE filter correlating region and nation tables. Verify that excluded columns (comment) are not present in the result set while join semantics match an equivalent explicit join between nation and region.	presto-tests/src/main/java/com/facebook/presto/tests/TestExcludeColumnsFunction.java
Add LATERAL join coverage for sequence table function.	Introduce testSequenceLateralJoin to assert behavior of system.builtin.sequence used as a table function in a CROSS JOIN LATERAL subquery. Compare TABLE(system.builtin.sequence(start => 1, stop => 5)) results to an equivalent CROSS JOIN UNNEST(sequence(1, 5)) with correlated filtering on nation and region keys.	presto-tests/src/main/java/com/facebook/presto/tests/TestSequenceFunction.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In testExcludeColumnsLateralJoin, the alias r is reused both for the table function (TABLE(...) r) and for the enclosing lateral subquery () r), which is legal but confusing; consider using distinct aliases to make it clearer which level each r refers to.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `testExcludeColumnsLateralJoin`, the alias `r` is reused both for the table function (`TABLE(...) r`) and for the enclosing lateral subquery (`) r`), which is legal but confusing; consider using distinct aliases to make it clearer which level each `r` refers to.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[aditi-pandit]

Thanks @mohsaka for these tests. Had a question about them.

[aditi-pandit]

@mohsaka : What is the purpose of LATERAL here ? Were you not able to do the same logic with the same SQL without LATERAL ?

[mohsaka]

We can, per the expected SQL which has the same result. But I thought we wanted to test lateral in combination with the exclude columns table function result?