fix: Use namespaced GTest targets in arrow_flight tests#27137
Open
jkhaliqi wants to merge 1 commit intoprestodb:masterfrom
Open
fix: Use namespaced GTest targets in arrow_flight tests#27137jkhaliqi wants to merge 1 commit intoprestodb:masterfrom
jkhaliqi wants to merge 1 commit intoprestodb:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Arrow Flight connector test CMake configuration to link against the modern, namespaced GTest imported targets instead of raw library names, fixing linker errors when building with the Arrow Flight connector enabled. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
czentgr
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed CMake linking error in Arrow Flight connector tests by using namespaced GTest imported targets (
GTest::gtest,GTest::gtest_main) instead of plain library names (gtest,gtest_main).Motivation and Context
The Arrow Flight connector tests were failing to link with the error
ld: library 'gtest' not foundbecause theCMakeLists.txtwas using old-style plain library names instead of modern CMake imported targets. This prevented building Presto with-DPRESTO_ENABLE_ARROW_FLIGHT_CONNECTOR=ON.Impact
Test Plan
-DPRESTO_ENABLE_ARROW_FLIGHT_CONNECTOR=ONpresto_flight_connector_testexecutable links successfullyContributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
Summary by Sourcery
Fix Arrow Flight connector test build by linking against the correct GoogleTest CMake targets.
Bug Fixes:
Build: