Skip to content

refactor: Update TempDirectoryPath and TempFilePath path#27203

Open
duxiao1212 wants to merge 2 commits intoprestodb:masterfrom
duxiao1212:xiao2602241updatepath
Open

refactor: Update TempDirectoryPath and TempFilePath path#27203
duxiao1212 wants to merge 2 commits intoprestodb:masterfrom
duxiao1212:xiao2602241updatepath

Conversation

@duxiao1212
Copy link
Contributor

@duxiao1212 duxiao1212 commented Feb 24, 2026

Description

Velox updated TempDirectoryPath and TempFilePath from velox/exec/tests/utils/ to
velox/common/testutil/ for better reusability across the codebase.
We got to update accordingly

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

Summary by Sourcery

Update the Velox submodule used by presto-native-execution to a newer revision that relocates TempDirectoryPath and TempFilePath utilities.

Build:

  • Bump the presto-native-execution Velox submodule reference to a newer upstream commit.

Chores:

  • Align native execution dependencies with the updated Velox test utilities layout.

@duxiao1212 duxiao1212 requested review from a team as code owners February 24, 2026 18:48
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Feb 24, 2026
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 24, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update references to Velox TempDirectoryPath and TempFilePath helpers to use their new common location, keeping tests and native execution code in sync with upstream Velox changes.

File-Level Changes

Change Details Files
Align TempDirectoryPath and TempFilePath usages with their new velox/common/testutil/ location.
  • Replace includes or using-declarations that referenced velox/exec/tests/utils/TempDirectoryPath and TempFilePath with the new velox/common/testutil/ path.
  • Adjust any namespace or symbol references if required by the new utility location so that tests and helper code continue to compile.
  • Remove or stop using obsolete paths or local aliases that pointed at the old test utils directory.
presto-native-execution/velox/...

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@duxiao1212 duxiao1212 changed the title Update TempDirectoryPath and TempFilePath path refactor: Update TempDirectoryPath and TempFilePath path Feb 24, 2026
@duxiao1212 duxiao1212 force-pushed the xiao2602241updatepath branch 4 times, most recently from 3848dca to 4863718 Compare February 24, 2026 20:00
@duxiao1212 duxiao1212 requested a review from xiaoxmeng February 24, 2026 20:16
xiaoxmeng
xiaoxmeng previously approved these changes Feb 25, 2026
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duxiao1212 thanks!

@duxiao1212 duxiao1212 force-pushed the xiao2602241updatepath branch 2 times, most recently from 80c7b69 to d060ccd Compare February 26, 2026 18:02
@duxiao1212 duxiao1212 force-pushed the xiao2602241updatepath branch from d060ccd to 988d6e9 Compare February 26, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants