refactor: Update TempDirectoryPath and TempFilePath path#27203
Open
duxiao1212 wants to merge 2 commits intoprestodb:masterfrom
Open
refactor: Update TempDirectoryPath and TempFilePath path#27203duxiao1212 wants to merge 2 commits intoprestodb:masterfrom
duxiao1212 wants to merge 2 commits intoprestodb:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate references to Velox TempDirectoryPath and TempFilePath helpers to use their new common location, keeping tests and native execution code in sync with upstream Velox changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
3848dca to
4863718
Compare
80c7b69 to
d060ccd
Compare
d060ccd to
988d6e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Velox updated TempDirectoryPath and TempFilePath from velox/exec/tests/utils/ to
velox/common/testutil/ for better reusability across the codebase.
We got to update accordingly
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
Summary by Sourcery
Update the Velox submodule used by presto-native-execution to a newer revision that relocates TempDirectoryPath and TempFilePath utilities.
Build:
Chores: