fix(native): Remove key_sampling_percent from native Sql invoked functions and Advance velox#27210
Draft
pramodsatya wants to merge 1 commit intoprestodb:masterfrom
Draft
fix(native): Remove key_sampling_percent from native Sql invoked functions and Advance velox#27210pramodsatya wants to merge 1 commit intoprestodb:masterfrom
pramodsatya wants to merge 1 commit intoprestodb:masterfrom
Conversation
…tions and Advance velox
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the native SQL-invoked implementation of key_sampling_percent now that it is built into Velox, and advances the Velox submodule accordingly to avoid duplicate function registration and signature conflicts. Class diagram for updated native SQL-invoked functions pluginclassDiagram
class NativeSqlInvokedFunctionsPlugin {
+Set~Class~ getSqlInvokedFunctions()
}
class NativeArraySqlFunctions
class NativeMapSqlFunctions
%% NativeSimpleSamplingPercent has been removed and is no longer registered
NativeSqlInvokedFunctionsPlugin ..> NativeArraySqlFunctions : registers
NativeSqlInvokedFunctionsPlugin ..> NativeMapSqlFunctions : registers
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
key_sampling_percentis now a built-in function in Velox (ref: facebookincubator/velox#16113), it should no longer be registered as a native sql invoked function.Motivation and Context
Fixes tests error seen during submodule update:
The same error also appears to have impacted #27193.
Summary by Sourcery
Remove the deprecated native SQL-invoked implementation of key_sampling_percent and advance the Velox submodule to rely on its built-in function instead.
Bug Fixes:
Enhancements: