Open
Conversation
adrienntindall
requested changes
Feb 14, 2026
Collaborator
adrienntindall
left a comment
adrienntindall
left a comment
There was a problem hiding this comment.
Overall good work, I just have a few requests to get things up to gen4 standard
FrontierMon->FrontierMonNarcData FrontierMonStruct->FrontierMon
adrienntindall
previously approved these changes
Feb 17, 2026
Collaborator
adrienntindall
left a comment
adrienntindall
left a comment
There was a problem hiding this comment.
Looks good to me! There's just one merge conflict that needs to be resolved and it should be good.
Also one more note for the future, we don't usually name sub_XXXXXXXXX to FrontierFieldSystem_XXXXXXXX when we still don't know what the function does, but I wasn't clear and it's ultimately not a big issue so I'm not going to ask for it to be undone.
adrienntindall
approved these changes
Feb 17, 2026
Collaborator
|
Build failed, looks like a syntax error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first time attempting a PR to the decomp instead of hg-engine so please be nice :)
I noticed there were a ton of unknown vars and functions, and with some back-and-forth sleuthing I was able to identify quite a lot of them. Much of the remaining unknown data in these files is rooted in reading save data or other info that is still in raw asm, and I don't have the capacity right now to set up Ghidra or a similar tool and figure them out myself.
As for the naming schemes for vars or functions, I apologize if they're a bit generic or verbose-- happy to change anything upon request.