Skip to content

Decompile unk_020971F8#455

Open
ferwardle wants to merge 5 commits intopret:masterfrom
ferwardle:decomp/unk_020971F8
Open

Decompile unk_020971F8#455
ferwardle wants to merge 5 commits intopret:masterfrom
ferwardle:decomp/unk_020971F8

Conversation

@ferwardle
Copy link
Contributor

No description provided.

adrienntindall
adrienntindall previously approved these changes Feb 21, 2026
Copy link
Collaborator

@adrienntindall adrienntindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While nothing here is technically wrong, I'd like you to use a little bit more discretion choosing the next decompilation target since this file will have to be almost fully rewritten when we do get to overlay 44.

Notably all the function signatures using void* arguments will have to be updated since they're very clearly meant to be structs-- we just don't know which ones yet, and if you aren't going to touch overlay 44 then it's not really worth trying to define them right now.

Since the file is small anyways, I'll allow it through for now, but in the future if you want to try documenting a file that references a lot of void* unknowns I would suggest digging a bit deeper and trying to resolve struct definitions and such before continuing onward.

@PikalaxALT
Copy link
Collaborator

Build failed

@ferwardle
Copy link
Contributor Author

Will see if I can find more context in overlay_44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants