Sync pokemon.c with pokeheartgold and pokediamond#863
Closed
AsparagusEduardo wants to merge 77 commits intopret:mainfrom
Closed
Sync pokemon.c with pokeheartgold and pokediamond#863AsparagusEduardo wants to merge 77 commits intopret:mainfrom
pokemon.c with pokeheartgold and pokediamond#863AsparagusEduardo wants to merge 77 commits intopret:mainfrom
Conversation
Contributor
Author
|
New set of changes. As always, the description was updated as well: CHANGES |
pokemon.c with pokeheartgold and pokediamondpokemon.c with pokeheartgold and pokediamond
Contributor
Author
|
While there's still some work to do, I believe I've reached the point to stop and leave this ready for discussion and review. |
Contributor
Author
|
Updated PR and description with latest suggestions on the Discord thread. Note: In the middle column, functions that have "BattleFrontier" in pokeplatinum and pokeheartgold are refered as "BattleTower" in pokediamond. |
Contributor
Author
|
Added incoming pokeplatinum name changes (description updated) CHANGES |
Contributor
Author
|
Closing until pokeheartgold is beyond 70% decomped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matching PRs
pokemon.cwith pokeplatinum and pokediamond pokeheartgold#427pokemon.cwith pokeplatinum and pokeheartgold pokediamond#577Notes:
*for easier visibility.FunctionDPin pokeplatinum and pokeheartgold is just calledFunctionin pokediamond.Lists of changes:
BoxPokemon functions
Pokemon functions
SpeciesData functions
Species Data Params
Species functions
ExpRate functions
Personality functions
Nature/Flavor labels
Pokemon Sprite Template labels
Pokemon Sprite Template functions
Y Offset functions
Pokérus functions
Form change functions
Battle Frontier/Tower(DP) labels
Evolution labels
General define/enum renames
Species Form defines/enums
Friendship event constants