Document route 202 and jubilife city scripts#933
Open
Document route 202 and jubilife city scripts#933
Conversation
scbroede
reviewed
Feb 8, 2026
generated/vars_flags.txt
Outdated
| FLAG_UNK_0x01F7 | ||
| FLAG_HIDE_JUBILIFE_CITY_CLOWNS_1_AND_2 | ||
| FLAG_HIDE_JUBILIFE_CITY_MIDDLE_AGED_MAN | ||
| FLAG_HIDE_POKETCH_CO_1F_MIDDLE_AGED_MAN |
Collaborator
There was a problem hiding this comment.
would there be value in calling these two "poketch co president" instead of "middle aged man"?
res/text/jubilife_city.json
Outdated
| }, | ||
| { | ||
| "id": "pl_msg_00000023_00010", | ||
| "id": "JubilifeCity_Text_LucasThatManWhatsHeDoing", |
Collaborator
There was a problem hiding this comment.
nitpick:
Suggested change
| "id": "JubilifeCity_Text_LucasThatManWhatsHeDoing", | |
| "id": "JubilifeCity_Text_LucasThatGuyWhatsHeDoing", |
res/text/jubilife_city.json
Outdated
| }, | ||
| { | ||
| "id": "pl_msg_00000023_00036", | ||
| "id": "JubilifeCity_Text_TellmeHaveYouNotObtainedAPalPad", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "id": "JubilifeCity_Text_TellmeHaveYouNotObtainedAPalPad", | |
| "id": "JubilifeCity_Text_TellMeHaveYouNotObtainedAPalPad", |
res/text/jubilife_city.json
Outdated
| }, | ||
| { | ||
| "id": "pl_msg_00000023_00044", | ||
| "id": "JubilifeCity_Text_YoucanAddAppsToYourPoketch", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "id": "JubilifeCity_Text_YoucanAddAppsToYourPoketch", | |
| "id": "JubilifeCity_Text_YouCanAddAppsToYourPoketch", |
generated/vars_flags.txt
Outdated
| FLAG_UNK_0x03F4 | ||
| FLAG_UNK_0x03F5 | ||
| FLAG_UNK_0x03F6 | ||
| FLAG_HIDE_ROUTE_202_POKEBALL |
Collaborator
There was a problem hiding this comment.
i would personally name these types of flags FLAG_OBTAINED_(LOCATION)_(ITEM). especially for later areas where there are multiple items and you need to disambiguate
ie. FLAG_OBTAINED_ROUTE_202_POTION
Contributor
Author
There was a problem hiding this comment.
done, I also documented the offsets and files for hidden/pokeball item scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents the route 202 and jubilife city script, event and text files. This does not include buildings in jubilife city to keep the PR from getting too big.