Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on pret/pokecrystal#1205
There are probably more useful properties we could copy from the clang-format docs or rgbds. It will likely also need tweaking after trying to format the other tools in pokecrystal.
The 200-character line length is unnecessarily long, but going down to 100 or 120 or even 140 causes some wrapping in deeply-nested complex
forloops that we may not want.Some changes cannot be made by clang-format (except maybe the bleeding-edge latest version), so must be done manually, including:
{0}at the end of longoptionarrays or inlineenumdeclarations)// clang-format off