storing offsets in a Map instead of passing them down through an array (#1061)

Author: Janther

jest.config.js

@@ -2,13 +2,9 @@ const TEST_STANDALONE = Boolean(process.env.TEST_STANDALONE);
 const testMatch = ['<rootDir>/tests/format/**/format.test.js'];
 
 if (TEST_STANDALONE) {
-  testMatch.push(
-    '<rootDir>/tests/integration/**/*.test.js',
-    '<rootDir>/tests/unit/prettier-version/**/*.test.js'
-  );
+  testMatch.push('<rootDir>/tests/integration/**/*.test.js');
 } else {
   testMatch.push('<rootDir>/tests/unit/**/*.test.js');
-  testMatch.push('<rootDir>/tests/unit/**/*.test.ts');
 }
 
 export default {

src/slang-nodes/AbicoderPragma.ts

@@ -15,11 +15,10 @@ export class AbicoderPragma implements SlangNode {
 
   version: Identifier;
 
-  constructor(ast: ast.AbicoderPragma, offset: number) {
-    const metadata = getNodeMetadata(ast, offset);
-    const { offsets } = metadata;
+  constructor(ast: ast.AbicoderPragma) {
+    const metadata = getNodeMetadata(ast);
 
-    this.version = new Identifier(ast.version, offsets[0]);
+    this.version = new Identifier(ast.version);
 
     this.comments = metadata.comments;
     this.loc = metadata.loc;

src/slang-nodes/AdditiveExpression.ts

@@ -24,17 +24,12 @@ export class AdditiveExpression implements SlangNode {
 
   rightOperand: Expression;
 
-  constructor(
-    ast: ast.AdditiveExpression,
-    offset: number,
-    options: ParserOptions<AstNode>
-  ) {
-    let metadata = getNodeMetadata(ast, offset);
-    const { offsets } = metadata;
+  constructor(ast: ast.AdditiveExpression, options: ParserOptions<AstNode>) {
+    let metadata = getNodeMetadata(ast);
 
-    this.leftOperand = new Expression(ast.leftOperand, offsets[0], options);
+    this.leftOperand = new Expression(ast.leftOperand, options);
     this.operator = ast.operator.unparse();
-    this.rightOperand = new Expression(ast.rightOperand, offsets[1], options);
+    this.rightOperand = new Expression(ast.rightOperand, options);
 
     metadata = updateMetadata(metadata, [this.leftOperand, this.rightOperand]);
 

src/slang-nodes/AddressType.ts

@@ -15,8 +15,8 @@ export class AddressType implements SlangNode {
 
   payableKeyword?: string;
 
-  constructor(ast: ast.AddressType, offset: number) {
-    const metadata = getNodeMetadata(ast, offset);
+  constructor(ast: ast.AddressType) {
+    const metadata = getNodeMetadata(ast);
 
     this.payableKeyword = ast.payableKeyword?.unparse();
 

src/slang-nodes/AndExpression.ts

@@ -21,17 +21,12 @@ export class AndExpression implements SlangNode {
 
   rightOperand: Expression;
 
-  constructor(
-    ast: ast.AndExpression,
-    offset: number,
-    options: ParserOptions<AstNode>
-  ) {
-    let metadata = getNodeMetadata(ast, offset);
-    const { offsets } = metadata;
+  constructor(ast: ast.AndExpression, options: ParserOptions<AstNode>) {
+    let metadata = getNodeMetadata(ast);
 
-    this.leftOperand = new Expression(ast.leftOperand, offsets[0], options);
+    this.leftOperand = new Expression(ast.leftOperand, options);
     this.operator = ast.operator.unparse();
-    this.rightOperand = new Expression(ast.rightOperand, offsets[1], options);
+    this.rightOperand = new Expression(ast.rightOperand, options);
 
     metadata = updateMetadata(metadata, [this.leftOperand, this.rightOperand]);
 

src/slang-nodes/ArgumentsDeclaration.ts

@@ -17,26 +17,19 @@ export class ArgumentsDeclaration implements SlangNode {
 
   variant: PositionalArgumentsDeclaration | NamedArgumentsDeclaration;
 
-  constructor(
-    ast: ast.ArgumentsDeclaration,
-    offset: number,
-    options: ParserOptions<AstNode>
-  ) {
-    let metadata = getNodeMetadata(ast, offset);
-    const { offsets } = metadata;
+  constructor(ast: ast.ArgumentsDeclaration, options: ParserOptions<AstNode>) {
+    let metadata = getNodeMetadata(ast);
 
     switch (ast.variant.cst.kind) {
       case NonterminalKind.PositionalArgumentsDeclaration:
         this.variant = new PositionalArgumentsDeclaration(
           ast.variant as ast.PositionalArgumentsDeclaration,
-          offsets[0],
           options
         );
         break;
       case NonterminalKind.NamedArgumentsDeclaration:
         this.variant = new NamedArgumentsDeclaration(
           ast.variant as ast.NamedArgumentsDeclaration,
-          offsets[0],
           options
         );
         break;

src/slang-nodes/ArrayExpression.ts

@@ -19,15 +19,10 @@ export class ArrayExpression implements SlangNode {
 
   items: ArrayValues;
 
-  constructor(
-    ast: ast.ArrayExpression,
-    offset: number,
-    options: ParserOptions<AstNode>
-  ) {
-    let metadata = getNodeMetadata(ast, offset);
-    const { offsets } = metadata;
-
-    this.items = new ArrayValues(ast.items, offsets[0], options);
+  constructor(ast: ast.ArrayExpression, options: ParserOptions<AstNode>) {
+    let metadata = getNodeMetadata(ast);
+
+    this.items = new ArrayValues(ast.items, options);
 
     metadata = updateMetadata(metadata, [this.items]);
 

src/slang-nodes/ArrayTypeName.ts

@@ -19,17 +19,12 @@ export class ArrayTypeName implements SlangNode {
 
   index?: Expression;
 
-  constructor(
-    ast: ast.ArrayTypeName,
-    offset: number,
-    options: ParserOptions<AstNode>
-  ) {
-    let metadata = getNodeMetadata(ast, offset);
-    const { offsets } = metadata;
-
-    this.operand = new TypeName(ast.operand, offsets[0], options);
+  constructor(ast: ast.ArrayTypeName, options: ParserOptions<AstNode>) {
+    let metadata = getNodeMetadata(ast);
+
+    this.operand = new TypeName(ast.operand, options);
     if (ast.index) {
-      this.index = new Expression(ast.index, offsets[1], options);
+      this.index = new Expression(ast.index, options);
     }
 
     metadata = updateMetadata(metadata, [this.operand, this.index]);

src/slang-nodes/ArrayValues.ts

@@ -19,17 +19,10 @@ export class ArrayValues implements SlangNode {
 
   separators: string[];
 
-  constructor(
-    ast: ast.ArrayValues,
-    offset: number,
-    options: ParserOptions<AstNode>
-  ) {
-    let metadata = getNodeMetadata(ast, offset, true);
-    const { offsets } = metadata;
-
-    this.items = ast.items.map(
-      (item, index) => new Expression(item, offsets[index], options)
-    );
+  constructor(ast: ast.ArrayValues, options: ParserOptions<AstNode>) {
+    let metadata = getNodeMetadata(ast, true);
+
+    this.items = ast.items.map((item) => new Expression(item, options));
     this.separators = ast.separators.map((separator) => separator.unparse());
 
     metadata = updateMetadata(metadata, [this.items]);

src/slang-nodes/AssemblyFlags.ts

@@ -19,17 +19,10 @@ export class AssemblyFlags implements SlangNode {
 
   separators: string[];
 
-  constructor(
-    ast: ast.AssemblyFlags,
-    offset: number,
-    options: ParserOptions<AstNode>
-  ) {
-    let metadata = getNodeMetadata(ast, offset, true);
-    const { offsets } = metadata;
-
-    this.items = ast.items.map(
-      (item, index) => new StringLiteral(item, offsets[index], options)
-    );
+  constructor(ast: ast.AssemblyFlags, options: ParserOptions<AstNode>) {
+    let metadata = getNodeMetadata(ast, true);
+
+    this.items = ast.items.map((item) => new StringLiteral(item, options));
     this.separators = ast.separators.map((separator) => separator.unparse());
 
     metadata = updateMetadata(metadata, [this.items]);