Skip to content

Conversation

@Janther
Copy link
Contributor

@Janther Janther commented Dec 4, 2024

createParser now is also responsible for returning the pareOutput one of the reasons for returning both values is because the values are very related to each other and is easier to test this way.

@Janther Janther requested a review from fvictorio December 4, 2024 03:50
@Janther Janther force-pushed the minimise_use_of_parser branch from ad0d9ec to cc49d87 Compare December 10, 2024 23:05
@Janther Janther force-pushed the minimise_use_of_parser branch from 13bc858 to 8652dcb Compare December 18, 2024 01:54
…tant instead of creating the array in every call
@Janther Janther merged commit 03ae9de into v2 Dec 18, 2024
7 checks passed
@Janther Janther deleted the minimise_use_of_parser branch December 18, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants