-
-
Notifications
You must be signed in to change notification settings - Fork 263
Disable @stylistic/curly-newline
#342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughA new stylistic rule, Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 5c04f61 in 31 seconds. Click for details.
- Reviewed
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. index.js:49
- Draft comment:
Added '@stylistic/curly-newline' disabled rule. The insertion is consistent with surrounding rules and follows alphabetical placement. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_baeO7kjKYvRgsW3T
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
@stylistic/curly-newline
Thanks for the PR first, the rules are auto generated from https://github.com/prettier/eslint-config-prettier/blob/main/scripts/generate-stylistic.js, so |
So presumably this will take care of it, it's been open for a while though |
Introduced in October 2024: https://github.com/eslint-stylistic/eslint-stylistic/releases/tag/v2.9.0
https://eslint.style/rules/curly-newline
Important
Disables
@stylistic/curly-newline
rule inindex.js
, aligning with other stylistic rules disabled for Prettier.@stylistic/curly-newline
rule inindex.js
by setting it to "off".@stylistic/curly-newline
was introduced in October 2024.This description was created by
for 5c04f61. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit