Skip to content

Conversation

fregante
Copy link

@fregante fregante commented Aug 7, 2025

Introduced in October 2024: https://github.com/eslint-stylistic/eslint-stylistic/releases/tag/v2.9.0

https://eslint.style/rules/curly-newline


Important

Disables @stylistic/curly-newline rule in index.js, aligning with other stylistic rules disabled for Prettier.

  • Behavior:
    • Disables @stylistic/curly-newline rule in index.js by setting it to "off".
    • Aligns with other stylistic rules that are disabled when using Prettier.
  • Context:
    • @stylistic/curly-newline was introduced in October 2024.

This description was created by Ellipsis for 5c04f61. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Chores
    • Disabled enforcement of the curly newline stylistic rule.

Copy link

changeset-bot bot commented Aug 7, 2025

⚠️ No Changeset found

Latest commit: 5c04f61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

coderabbitai bot commented Aug 7, 2025

Walkthrough

A new stylistic rule, "@stylistic/curly-newline": "off", has been added to the list of disabled rules in the exported configuration object within index.js. No other changes to logic, control flow, or exports are present.

Changes

Cohort / File(s) Change Summary
Stylistic Rule Configuration
index.js
Disabled the @stylistic/curly-newline rule by setting it to "off" in the exported rules object.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop and a skip, a curly brace anew,
Stylistic rules now bid adieu.
With "curly-newline" set to "off" in the sun,
Our linting journey is smoothly run.
🐇✨ No more newline fuss,
The code looks fine to us!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b0b0a4 and 5c04f61.

📒 Files selected for processing (1)
  • index.js (1 hunks)
🔇 Additional comments (2)
index.js (2)

49-49: New rule correctly disabled – in line with project goals
Adding @stylistic/curly-newline to the “always-off” list is consistent with the purpose of this package (turning off formatting rules that clash with Prettier). Alphabetical ordering within the block is preserved, so no further action is required.


49-49: Optional check – confirm language-specific aliases aren’t missing
Many stylistic rules exist in triplicate (@stylistic/<base>, @stylistic/js/<base>, @stylistic/ts/<base>). If the plugin later ships @stylistic/js/curly-newline or @stylistic/ts/curly-newline, we’ll want to disable those too. Worth a quick scan of the released rule list to ensure there are no siblings that still default to “error”.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 5c04f61 in 31 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. index.js:49
  • Draft comment:
    Added '@stylistic/curly-newline' disabled rule. The insertion is consistent with surrounding rules and follows alphabetical placement.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_baeO7kjKYvRgsW3T

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@fregante fregante changed the title Disable @stylistic/curly-newline` Disable @stylistic/curly-newline Aug 7, 2025
@JounQin
Copy link
Member

JounQin commented Aug 7, 2025

Thanks for the PR first, the rules are auto generated from https://github.com/prettier/eslint-config-prettier/blob/main/scripts/generate-stylistic.js, so @stylistic/eslint-plugin needs to be upgraded.

@fregante
Copy link
Author

fregante commented Aug 7, 2025

So presumably this will take care of it, it's been open for a while though

@fregante fregante closed this Aug 7, 2025
@fregante fregante deleted the patch-1 branch August 23, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants