Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the bundling configuration to include the entire Prettier package as a dependency in the VS Code extension package, rather than excluding dependencies during packaging.
Key changes:
- Modified
.vscodeignoreto properly include all Prettier node_modules files - Removed
--no-dependenciesflag from allvsce packageandvsce publishcommands to bundle dependencies
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.vscodeignore |
Updated ignore patterns to include the complete Prettier package directory and its contents |
.github/workflows/main.yaml |
Removed --no-dependencies flag from package and publish commands to enable dependency bundling |
Comment on lines
+25
to
+26
| !node_modules/prettier/ | ||
| !node_modules/prettier/** |
There was a problem hiding this comment.
The pattern !node_modules/prettier/ on line 25 is redundant since line 26's pattern !node_modules/prettier/** already includes the directory itself and all its contents. Consider removing line 25 to avoid duplication.
Suggested change
| !node_modules/prettier/ | |
| !node_modules/prettier/** | |
| !node_modules/prettier/** |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.