Skip to content

Fixed typo and added note on trait upcasting #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed typo and added note on trait upcasting #98

wants to merge 2 commits into from

Conversation

styvane
Copy link

@styvane styvane commented Jul 30, 2025

  • Fixed typo
  • Added note that Trait upcasting is stable starting from 1.86

@styvane styvane changed the title Fixed typo and added not for upcasting Fixed typo and added note on trait upcasting Jul 30, 2025
lebensterben
lebensterben approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@lebensterben lebensterben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhnap
Copy link

mhnap commented Aug 12, 2025

@styvane @lebensterben Hi! Do you need any help to move forward with this PR?

@lebensterben
Copy link
Contributor

I've no push access. I'm just a contributor not a maintainer or owner of this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lebensterben lebensterben lebensterben approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@styvane @mhnap @lebensterben