Skip to content

Updated isMultiSelectEnabled to support ctrl key on windows #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated isMultiSelectEnabled to support ctrl key on windows #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/core/src/editor/store.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ export const editorInitialState: EditorState = {
handlers: (store) =>
new DefaultEventHandlers({
store,
isMultiSelectEnabled: (e: MouseEvent) => !!e.metaKey,
isMultiSelectEnabled: (e: MouseEvent) =>
navigator.userAgent.includes('Mac') ? !!e.metaKey : !!e.ctrlKey,
}),
normalizeNodes: () => {},
},
Expand Down
2 changes: 1 addition & 1 deletion site/docs/guides/basic-tutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@ const { currentlySelectedId } = useEditor((state) => {
})
```

> Note: state.events.selected is of type `Set<string>`. This is because in the case of multi-select, it's possible for the user to select multiple Nodes by holding down the `<meta>` key.
> Note: state.events.selected is of type `Set<string>`. This is because in the case of multi-select, it's possible for the user to select multiple Nodes by holding down the `<meta>` key (Mac) or `<ctrl>` key (Windows).

Now, let's replace the placeholder text fields in our Settings Panel with the `settings` Related Component:

Expand Down