Skip to content

fix: Deprecated: element.ref #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Deprecated: element.ref #732

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37a9605
fix: Deprecated: element.ref
manelpb Mar 9, 2025
85f82ee
support backwards compatibility with the old input format
manelpb Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fluffy-pumas-smile.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@craftjs/utils': patch
---

Accessing element.ref is no longer supported. ref is now a regular prop.
2 changes: 1 addition & 1 deletion packages/utils/src/EventHandlers/wrapConnectorHooks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function cloneWithRef(
element: any,
newRef: any
): React.ReactElement<any> {
const previousRef = element.ref;
const previousRef = element.props.ref;
invariant(
typeof previousRef !== 'string',
'Cannot connect to an element with an existing string ref. ' +
Expand Down