Open
Conversation
Contributor
oaliaga
commented
Mar 5, 2026
oaliaga
commented
- Fix multiple locations.
- Fix isTablet.
- Do not show settings in QR code.
- New Kotlin classes.
Deprecated classes
Deprecated classes
New Kotlin classes
Remove deprecated
New version 2.7.0
patriciojofre
requested changes
Mar 10, 2026
Member
patriciojofre
left a comment
patriciojofre
left a comment
There was a problem hiding this comment.
- faltan test de los cambios.
- limpiar el uso de try { } catch
- implementar utils para funciones que se pueden reutilizar
| PreyLogger.d("Alert start options:${options}") | ||
| val notificationId = AlertConfig.getAlertConfig(context).getNotificationId() | ||
| var alertMessage: String? = "" | ||
| try { |
Member
There was a problem hiding this comment.
este catch no es necesario, el mensaje siempre se envía con alert_message, no message
Member
There was a problem hiding this comment.
Suggested change
| try { | |
| alertMessage = options.getString("alert_message") ?: "" |
app/src/main/java/com/prey/actions/aware/AwareGeofenceManagerImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/prey/json/actions/LocationLowBattery.java
Outdated
Show resolved
Hide resolved
Deprecated classes
Tests are added
setInitialTrigger is set
Serial reception via MDM is added
The code was improved
Location Low Battery logic is changed
Ensure that a daily location is sent.
Fix report
patriciojofre
requested changes
Mar 18, 2026
app/src/androidTest/java/com/prey/actions/location/daily/DailyLocationWorkerTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/prey/actions/location/daily/DailyStoreTest.kt
Outdated
Show resolved
Hide resolved
| // Este test simula que la app se cierra y se abre (re-leyendo los SharedPreferences) | ||
| DailyStore.markSent(context) | ||
| val result = DailyStore.wasSentToday(context) | ||
| assertTrue("Los datos deben persistir en SharedPreferences", result) |
app/src/androidTest/java/com/prey/actions/location/LocationUtilTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/prey/actions/location/PreyLocationTest.kt
Outdated
Show resolved
Hide resolved
| RestrictionsManager restrictionsManager = (RestrictionsManager) context.getSystemService(Context.RESTRICTIONS_SERVICE); | ||
| // Retrieve the application restrictions | ||
| Bundle restrictions = restrictionsManager.getApplicationRestrictions(); | ||
| if (restrictions != null && restrictions.containsKey("serial")) { |
Member
There was a problem hiding this comment.
es correcto que este tipo de cosas estén en este archivo de password?
Fix language
Remove file
Remove file
Fix language
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.