Refactor SCSS rules #1395
Merged
Refactor SCSS rules #1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modularity and maintainability
…and maintainability
Updates the Next.js dependency from version 15.3.7 to 15.3.8. This resolves potential issues and incorporates improvements introduced in the newer version.
Contributor
Author
|
@fgyimah 👋. This PR has quite a number of changes. But, it's basically resolving the SCSS issues in the console |
Contributor
Author
|
@fgyimah I sync'd this branch with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes through the scss warnings and deprecations from the syntax and updates them.
Migrated the codebase from Sass
@importto the module system (@useand@forward) to align with Sass deprecation and prepare for Dart Sass 3.0.0.Updated index files (
variables/index.scssandmixins/index.scss) to use@forwardfor re-exporting partials.Mixin files that import variables (
_typography.scss,_responsive.scss,_container.scss,_shadows.scss,_border-radius.scss,_images.scss) now use@usewith namespaced variables (e.g.,typography.$font-size-xl,spacing.$grid-spacing-mobile). Updatednext.config.jsto use@use ... as *in prependData to maintain global variable/mixin availability.Removed redundant
@importstatements from component files that were already covered by prependData. Fixed files loaded via@use(_container.scssand_typography.scss) to explicitly import their dependencies.Also resolved mixed declarations warnings by wrapping declarations that appear after mixins or nested rules in
& {}blocks. This preserves the intended CSS cascade order (mixins first, then overrides) and follows Sass recommendations.This also fixes the scss console errors!