Feature/78 커뮤니티 댓글 조회 기능 #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
m-a-king
approved these changes
Dec 2, 2024
Collaborator
m-a-king
left a comment
m-a-king
left a comment
There was a problem hiding this comment.
수고하셨습니다! 제 코드가 왜 섞인 걸까요??
댓글, 대댓글 구조는 오랜만에 코딩 테스트 문제를 본 느낌이네요...
DFS, 위상 정렬이 생각났습니다.
src/main/java/com/somemore/community/service/comment/DeleteCommunityCommentService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/somemore/community/dto/response/CommunityCommentResponseDto.java
Show resolved
Hide resolved
src/main/java/com/somemore/community/repository/comment/CommunityCommentRepositoryImpl.java
Show resolved
Hide resolved
Collaborator
There was a problem hiding this comment.
쉽지 않네요... 한참 이해해 봤는데, 삭제 때문에 복잡해진 것 같아요. 수고하셨습니다.
src/test/java/com/somemore/community/service/comment/CommunityCommentQueryServiceTest.java
Outdated
Show resolved
Hide resolved
- 기존 댓글 내용 -> "삭제된 댓글입니다"
- View 생성자 제거
- isDeleted 메서드 추가
- test isEqual("") -> isEmpty()
- Boolean -> boolean
- markAsDeleted 메서드 내에서 content 내용 변경 - 개행 추가
ayoung-dev
force-pushed
the
feature/78-add-community-comment-query
branch
from
61838f4 to
7152613
Compare
…project/WEB1_1_Bongdari_BE into feature/78-add-community-comment-query
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
👩💻 요구 사항과 구현 내용
댓글조회
✅ PR 포인트 & 궁금한 점
댓글-대댓글 구조로 조회를 처음 해봐서 service 쪽을 집중적으로 봐주셨으면 합니다..