Feature/107 선호물품 등록 엔드포인트 구현 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
leebs0521
reviewed
Dec 2, 2024
| Long id, | ||
| UUID centerId, | ||
| String itemName | ||
| ) { |
Collaborator
There was a problem hiding this comment.
저는 여태 등록의 경우에는 id만 반환해줬는데 선호물품아이디, 기관아이디, 아이템이름을 보내주는 이유가 있을까요?
Collaborator
Author
There was a problem hiding this comment.
피그마를 보고 넣어줬습니다 물품 추가, 삭제시 바로바로 웹페이지에 적용이 되는데
정합성을 유지하려면 필드를 넣어줘야할 것 같았습니다!
프론트가 구현 방식에 따라 다시 바뀔수도 있습니다
| // verify | ||
| verify(createPreferItemUseCase).createPreferItem(userId, requestDto); | ||
| } | ||
| } No newline at end of file |
m-a-king
approved these changes
Dec 2, 2024
Collaborator
m-a-king
left a comment
m-a-king
left a comment
There was a problem hiding this comment.
컨트롤러 테스트 잘 봤습니다! 어떤 느낌인지 점점 알 것 같아요. 수고하셨습니다!
ayoung-dev
approved these changes
Dec 2, 2024
- 컨트롤러 구현 - 기관 권한 설정에 따른 요청 Dto 수정 - 요청 Dto 변화에 따른 서비스 레이어 파라미터 값 수정 - 테스트 코드 작성및 검증 완
- 도메인 관점의 설명으로 변경
- 응답 객체에 swagger 스키마 적용 - 개행 추
7zrv
force-pushed
the
feature/107-add-preferitem-end-point
branch
from
e9762d1 to
a2d0845
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
기관의 선호물품 등록 엔드포인트 구현입니다.
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점