-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/113 커뮤니티 게시글, 댓글 조회 페이징 처리 #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 게시글 조회 ResponseDto 'Get' 삭제 - toEntity -> to / fromEntity -> from
- DTO to/from 변수명 반영 - 게시글, 댓글 조회 테스트 페이징 처리 반영
…project/WEB1_1_Bongdari_BE into feature/113-add-community-query-paging
2 tasks
leebs0521
reviewed
Dec 2, 2024
Collaborator
leebs0521
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~
src/main/java/com/somemore/community/dto/response/CommunityBoardDetailResponseDto.java
Show resolved
Hide resolved
src/main/java/com/somemore/community/dto/request/CommunityBoardCreateRequestDto.java
Show resolved
Hide resolved
src/main/java/com/somemore/community/dto/response/CommunityBoardResponseDto.java
Show resolved
Hide resolved
- to -> toEntity 변수명 변경 - ResponseDto 스웨거 적용
…project/WEB1_1_Bongdari_BE into feature/113-add-community-query-paging
leebs0521
approved these changes
Dec 2, 2024
m-a-king
approved these changes
Dec 3, 2024
Collaborator
m-a-king
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다
src/main/java/com/somemore/community/repository/board/CommunityBoardRepositoryImpl.java
Show resolved
Hide resolved
- 삭제 메서드 추출
…project/WEB1_1_Bongdari_BE into feature/113-add-community-query-paging
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점
사이즈가 변동될 거 같진 않아 한 페이지당 게시글은 10개, 댓글은 4개로 service에서 정해줬고 피그마 보고 정했습니다!