[FEATURE] 봉사활동 모집글 생성 기능 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- JpaAuditing annotation - 통합 테스트: 스프링 서버를 한번 띄우기 위해
Closed
2 tasks
ayoung-dev
reviewed
Nov 20, 2024
Collaborator
There was a problem hiding this comment.
궁금한게 있습니다!
- imgUrl이 원래 Optinal로 되어있었던 거 같은데 없어졌던데 Notnull로 처리하실 생각이신 걸까요?
- 저희 Service 안에서 command/query 한 번 더 나누기로 한 거 같은데 아직 파일이 하나뿐이라 따로 폴더에 안 넣으신건가요?
(이건 코드랑 상관 없는 질문인데)
혹시 테스트 코드 실행하시면 bytebuddy 관련된 WARNING 안뜨시나요?
혹시 뜨시면 어떻게 해결하셨나욤 방법이 여러개던데 통일하면 좋을 거 같아서요!
저도 범수님이 만들어주신 IntegrationTestSupport랑 test.yml 같은 파일 받아서 수정하고 올리는 게 좋을 거 같아서 범수님 코드 머지되면 PR 올리겠습니다!
고생하셨습니다아
ayoung-dev
reviewed
Nov 20, 2024
src/test/java/com/somemore/recruitboard/service/CreateRecruitBoardServiceTest.java
Show resolved
Hide resolved
Collaborator
Author
|
@ayoung-dev 1번은 Optional로 해둔게 맞았는데 어제 재중님 코드 리뷰 보고 컨트롤러에서 이미지가 없을경우 빈 문자열 |
7zrv
reviewed
Nov 21, 2024
src/main/java/com/somemore/location/dto/request/LocationCreateRequestDto.java
Outdated
Show resolved
Hide resolved
src/test/java/com/somemore/recruitboard/service/CreateRecruitBoardServiceTest.java
Show resolved
Hide resolved
m-a-king
reviewed
Nov 21, 2024
src/test/java/com/somemore/recruitboard/service/CreateRecruitBoardServiceTest.java
Show resolved
Hide resolved
- String -> Decimal
- String -> Decimal
leebs0521
commented
Nov 21, 2024
| @Column(name = "longitude", nullable = false) | ||
| private String longitude; | ||
| @Column(name = "longitude", nullable = false, precision = 12, scale = 8) | ||
| private BigDecimal longitude; |
Collaborator
Author
There was a problem hiding this comment.
정밀도를 8자리로 한이유
- 다음 글보고 정했습니다. https://pixx.tistory.com/380
7zrv
approved these changes
Nov 21, 2024
ayoung-dev
approved these changes
Nov 21, 2024
- command 패키지 하위로 이동
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점
RecruitBoard엔티티 필드 추가 및 타입 변경