[BUILD FAIL] Feature/137 Feature/137 봉사활동 모집글, 커뮤니티 게시글 검색 조회 (elastic search) #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keyword로 검색 결과 반환 - elasticsearch에 저장 - 전체 데이터 조회 - elasticsearch 데이터 삭제
- elasticsearch 저장 - elasticsearch 키워드 검색 - 전체글 조회
- application-test.yml 수정 - elastic search uris -> uri test(search): 코드 리뷰 사항 반영 - application-test.yml 수정
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
m-a-king
reviewed
Dec 9, 2024
Collaborator
m-a-king
left a comment
m-a-king
left a comment
There was a problem hiding this comment.
수고하셨습니다! 쿼리 고수가 되셨네요.
테스트 해결해야 할 텐데 왜 안되는 걸까요?
그리고 테스트에서 뭔가 매직 넘버들이 많은데 따라가는 게 조금 헷갈리는 것 같았어요.
Comment on lines
+145
to
+156
| private List<CommunityBoardDocument> convertEntityToDocuments(List<CommunityBoard> communityBoards) { | ||
| List<CommunityBoardDocument> communityBoardDocuments = new ArrayList<>(); | ||
|
|
||
| for (CommunityBoard communityboard : communityBoards) { | ||
| CommunityBoardDocument document = CommunityBoardDocument.builder() | ||
| .id(communityboard.getId()) | ||
| .title(communityboard.getTitle()) | ||
| .content(communityboard.getContent()) | ||
| .build(); | ||
| communityBoardDocuments.add(document); | ||
| } | ||
| return communityBoardDocuments; |
Collaborator
There was a problem hiding this comment.
서비스에 있으면 좋을 것 같은데 혹시 여기 있는 이유가 있나요?
Collaborator
Author
There was a problem hiding this comment.
documentRepository의 saveAll 사용하려고 repository에서 document로 바꿔주었습니다!
| this.title = title; | ||
| this.content = content; | ||
| } | ||
| } No newline at end of file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점