[FEATURE] 모집글 스케쥴링 #297
Merged
[FEATURE] 모집글 스케쥴링 #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
m-a-king
approved these changes
Jan 14, 2025
Collaborator
m-a-king
left a comment
m-a-king
left a comment
There was a problem hiding this comment.
수고하셨습니다.
디스코드 소통 내용만 봐도 상당히 검증 작업이 많이 필요해보였는데, 깔끔하게 구현해두셔서 편히 읽었습니다~
...main/java/com/somemore/domains/recruitboard/controller/RecruitBoardCommandApiController.java
Outdated
Show resolved
Hide resolved
...main/java/com/somemore/domains/recruitboard/scheduler/RecruitBoardStatusUpdateScheduler.java
Show resolved
Hide resolved
...main/java/com/somemore/domains/recruitboard/scheduler/RecruitBoardStatusUpdateScheduler.java
Outdated
Show resolved
Hide resolved
.../java/com/somemore/domains/recruitboard/scheduler/RecruitBoardStatusUpdateSchedulerTest.java
Show resolved
Hide resolved
...test/java/com/somemore/domains/recruitboard/service/validator/RecruitBoardValidatorTest.java
Outdated
Show resolved
Hide resolved
7zrv
reviewed
Jan 14, 2025
...main/java/com/somemore/domains/recruitboard/scheduler/RecruitBoardStatusUpdateScheduler.java
Outdated
Show resolved
Hide resolved
- RecruitStatus 기본 값 제거, 생성자 파라미터 추가 - 검증 로직 제거, 비지니스 로직 추가
- RecruitStatus 기본 값 제거, 생성자 파라미터 추가 - 검증 로직 제거, 비지니스 로직 추가
- 봉사 시작/종료 일시 수정시, 생성일 하루 이후부터 가능하도록 검증
- 봉사 시작/종료 일시 수정시, 생성일 하루 이후부터 가능하도록 검증
- 모집글 수정시 시간에 따른 검증 일괄 추가 - 봉사 시작 일시 전날까지 수정 가능하도록 검증
- 모집글 수정시 시간에 따른 검증 일괄 추가 - 봉사 시작 일시 전날까지 수정 가능하도록 검증
- 봉사 시작일 기준 모집완료(CLOSED) 변경 - 봉사 종료일 기준 완료(COMPLETED) 변경
- 봉사 시작일 기준 모집완료(CLOSED) 변경 - 봉사 종료일 기준 완료(COMPLETED) 변경
- 최대 시도, 주기 명시적으로 변경
leebs0521
force-pushed
the
feature/198-add-recruit-board-schedule
branch
from
e3c6562 to
97c9e20
Compare
- Service 계층에서 Clock 사용
- Service 계층에서 Clock 사용
- between()으로 변경
- between()으로 변경
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved:
📌 과제 설명
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점