[REFACTOR] 기관 선호 물품 리팩토링 #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
m-a-king
approved these changes
Feb 6, 2025
|
|
||
| centerQueryUseCase.validateCenterExists(centerId); | ||
|
|
||
| PreferItem preferItem = requestDto.toEntity(centerId); |
Collaborator
There was a problem hiding this comment.
dto.toEntity와 entity.from, entity.of를 구분하는 기준이 있으신가요?
Collaborator
Author
There was a problem hiding this comment.
이거 서진님이 작성하신 코드긴한데
저는 RequestDto -> Entity 는 무조건 Dto.toEntity를 사용하고
Entity -> ResponseDto 는 파라미터 개수에 따라 1개 from 2개이상 of를 사용하는 편이긴합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점