[FEATURE] 이미지 업로드 (프로필, 공통) #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-a-king
requested review from
7zrv,
ayoung-dev and
leebs0521
and removed request for
7zrv
m-a-king
changed the title
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
m-a-king
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
github-actions
bot
changed the title
m-a-king
changed the title
ayoung-dev
approved these changes
Feb 7, 2025
| @RequestBody CenterBasicInfoRequestDto centerBasicInfoRequestDto | ||
| ) { | ||
| updateBasicInfoUseCase.update(userId, centerBasicInfoRequestDto); | ||
| return ApiResponse.ok("센터 기본 정보 업데이 완료"); |
Collaborator
There was a problem hiding this comment.
업데이..!
중요한 건 아니지만.. 보였어요
leebs0521
approved these changes
Feb 7, 2025
| public ApiResponse<String> getImageUploadUrl( | ||
| @UserId UUID userId, | ||
| @RequestBody String fileName | ||
| ) { |
Collaborator
There was a problem hiding this comment.
@ReqeustBody에 ImgUrlRequestDto가 아닌 스트링으로 하신 이유가 있을까요??
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
이미지 업로드
👩💻 요구 사항과 구현 내용
프로필 수정에서 이미지를 분리했습니다.
공통 이미지 업로드 컨트롤러도 추가했습니다.
서진 님이 작성해주신 기존의 프로필 이미지 수정을 유저 프로필 이미지 수정으로 병합했습니다.
✅ PR 포인트 & 궁금한 점