[REFACTOR] 검색 리팩토링 #370
Merged
[REFACTOR] 검색 리팩토링 #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
leebs0521
approved these changes
Feb 7, 2025
| public String findNameById(UUID id) { | ||
| return findDynamicFieldByCenterId(id, userCommonAttribute.name) | ||
| .orElse(null); | ||
| } |
Collaborator
There was a problem hiding this comment.
여기그냥 Optional로 하는게 어떠신가요??
|
|
||
| if (name == null || name.isBlank()) { | ||
| throw new BadRequestException(NOT_EXISTS_CENTER); | ||
| } |
Collaborator
There was a problem hiding this comment.
위에 Optional로 바꾸면 여기서 .orElse() 에러 핸들링 될 같아요. 그리고 NoSuchEle~ 에러클래스가 더 어울릴 것 같아요
| private final CenterQueryUseCase centerQueryUseCase; | ||
| private final NEWVolunteerQueryUseCase volunteerQueryUseCase; | ||
| private final NEWCenterQueryUseCase centerQueryUseCase; | ||
| private final LocationQueryUseCase locationQueryUseCase; |
Collaborator
There was a problem hiding this comment.
여기 레포지토리인데 쿼리유스케이스가 있네요?
다음에 혹시 설명해주실수 있나요?
- 지금은 기능이 잘 동작하는거라면 괜찮습니다.
Collaborator
Author
There was a problem hiding this comment.
엇 다른 도메인의 메서드를 사용하는 거라 일부러 usecase로 가져와서 한 건데 repository로 하는게 맞을까요?
동작은 잘 되는데 의견 주시면 다음 리팩토링에 반영하겠습니다!
m-a-king
approved these changes
Feb 8, 2025
| public String findNameById(UUID id) { | ||
| return findDynamicFieldByCenterId(id, userCommonAttribute.name) | ||
| .orElse(null); | ||
| } |
- 불필요한 import 제거
- BadRequestException -> NoSuchElementException
ayoung-dev
force-pushed
the
refactor/364-modify-search
branch
from
b3f1c5e to
302f78e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점