Feature/26 봉사 모집글 수정 기능 #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 봉사 정보를 VolunteerInfo 객체에서 관리
- 모집 정보 수정 - 모집 위치 정보 수정
- 모집 정보 수정 테스트 - 모집 위치 정보 수정 테스트
Collaborator
Author
|
CI 테스트용으로 PR 올렸고 수정해야할 부분 더 있어서 일단 닫겠습니다. |
m-a-king
reviewed
Nov 25, 2024
Collaborator
m-a-king
left a comment
m-a-king
left a comment
There was a problem hiding this comment.
테스트 코드에서 감탄과 경악을 함께 느끼고 갑니다. 너무 수고하셨습니다.
전체적으로 클래스 마지막에 개행이 빠진 부분을 수정하셔야 할 것 같습니다. 서진 님이 오시기 전에...
src/main/java/com/somemore/location/repository/LocationRepositoryImpl.java
Show resolved
Hide resolved
src/main/java/com/somemore/location/service/command/UpdateLocationService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/somemore/location/service/query/LocationQueryService.java
Show resolved
Hide resolved
src/main/java/com/somemore/recruitboard/domain/RecruitBoard.java
Outdated
Show resolved
Hide resolved
src/main/java/com/somemore/recruitboard/domain/RecruitBoard.java
Outdated
Show resolved
Hide resolved
src/test/java/com/somemore/location/service/query/LocationQueryServiceTest.java
Show resolved
Hide resolved
7zrv
reviewed
Nov 25, 2024
7zrv
reviewed
Nov 25, 2024
src/main/java/com/somemore/recruitboard/dto/request/RecruitBoardCreateRequestDto.java
Outdated
Show resolved
Hide resolved
7zrv
reviewed
Nov 25, 2024
src/main/java/com/somemore/recruitboard/service/command/UpdateRecruitBoardService.java
Show resolved
Hide resolved
7zrv
reviewed
Nov 25, 2024
src/main/java/com/somemore/recruitboard/service/query/RecruitQueryService.java
Outdated
Show resolved
Hide resolved
ayoung-dev
reviewed
Nov 26, 2024
src/main/java/com/somemore/recruitboard/service/command/UpdateRecruitBoardService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/somemore/recruitboard/service/query/RecruitQueryService.java
Outdated
Show resolved
Hide resolved
|
m-a-king
approved these changes
Nov 26, 2024
7zrv
approved these changes
Nov 26, 2024
ayoung-dev
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점