Feature/19 커뮤니티 게시글 조회 기능 #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 커뮤니티 게시글 목록 조회 - 커뮤니티 게시글 목록 사용자별 조회 - 커뮤니티 게시글 상세 조회
Closed
3 tasks
m-a-king
reviewed
Nov 25, 2024
Collaborator
m-a-king
left a comment
m-a-king
left a comment
There was a problem hiding this comment.
수고 많으셨습니다!
역시 비즈니스 로직은 다양한 케이스를 커버해야 하다 보니 꼼꼼히 확인하시느라 시간이 많이 걸리셨을 것 같아요.
src/main/java/com/somemore/center/dto/response/CenterForCommunityResponseDto.java
Show resolved
Hide resolved
src/main/java/com/somemore/community/service/query/CommunityBoardQueryService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/somemore/community/service/query/CommunityBoardQueryService.java
Show resolved
Hide resolved
src/main/java/com/somemore/volunteer/service/query/FindVolunteerIdService.java
Show resolved
Hide resolved
src/main/java/com/somemore/volunteer/repository/VolunteerRepositoryImpl.java
Show resolved
Hide resolved
src/test/java/com/somemore/community/repository/CommunityRepositoryTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/somemore/community/repository/CommunityRepositoryTest.java
Show resolved
Hide resolved
src/test/java/com/somemore/community/service/query/CommunityBoardQueryServiceTest.java
Show resolved
Hide resolved
src/test/java/com/somemore/community/service/query/CommunityBoardQueryServiceTest.java
Show resolved
Hide resolved
leebs0521
approved these changes
Nov 26, 2024
src/test/java/com/somemore/community/repository/CommunityRepositoryTest.java
Show resolved
Hide resolved
m-a-king
approved these changes
Nov 26, 2024
7zrv
approved these changes
Nov 26, 2024
Collaborator
|
코드 꼼꼼하게 작성하셨군요 고생하셨습니다. |
- repository 테스트 usecase 주입 - getWriterDetail 메서드 else문 삭제
…project/WEB1_1_Bongdari_BE into feature/19-get-community-board # Conflicts: # src/main/java/com/somemore/global/exception/ExceptionMessage.java
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
커뮤니티 게시글 조회 기능
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점
작성자 정보 조회 과정에서 center와 volunteer responseDto를 WriterDetailDto interface를 implements 받는 구조로 구현하였는데 WriterDetailDto 이름이나 디렉토리 위치가 어떤지 리뷰 남겨주시면 감사하겠습니다!