Refactor/51 커뮤니티 게시글 id로 조회 로직 QueryDSL로 변경 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoung-dev
changed the title
m-a-king
approved these changes
Nov 26, 2024
| public interface CommunityBoardRepository { | ||
| CommunityBoard save(CommunityBoard communityBoard); | ||
| Optional<CommunityBoard> findById(Long id); | ||
| Optional<CommunityBoard> getCommunityBoardWithId(Long id); |
Collaborator
There was a problem hiding this comment.
- repository에서 find 키워드를 더 많이 사용하지 않나요?
- CommunityBoardRepository라면 findById만 사용하면 되지 않나요?
Suggested change
| Optional<CommunityBoard> getCommunityBoardWithId(Long id); | |
| Optional<CommunityBoard> findById(Long id); |
Collaborator
There was a problem hiding this comment.
2번 설명이 좀 부족했는데, get을 사용하더라도
getById()
getWithId() 로 처리 가능하지 않은지 여쭤본 겁니다!
…getCommunityBoardsByWriterId -> findByWriterId 이름 변경
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
findById 조회 기능 JPA -> QueryDSL
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점
삭제된 게시글의 경우에도 조회가 되어 QueryDSL로 deleted 조건 추가하였습니다.