Feature/47 커뮤니티 게시글 삭제 기능 #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project/WEB1_1_Bongdari_BE into feature/47-add-community-board-delete
Closed
2 tasks
7zrv
reviewed
Nov 26, 2024
|
|
||
| @Override | ||
| public void deleteCommunityBoard(UUID writerId, Long id) { | ||
| CommunityBoard communityBoard = communityBoardRepository.findById(id) |
Collaborator
There was a problem hiding this comment.
아래에 valiadteWriter처럼 메서드로 빼서 추상화 레벨 맞춰주는것도 좋아보여요!
m-a-king
approved these changes
Nov 26, 2024
Comment on lines
40
to
44
| CommunityBoardCreateRequestDto dto = CommunityBoardCreateRequestDto.builder() | ||
| .title("커뮤니티 테스트 제목") | ||
| .content("커뮤니티 테스트 내용") | ||
| .build(); | ||
|
|
Collaborator
There was a problem hiding this comment.
중복되는 부분이 눈에 띄는데 @BeforeEach를 사용해보는 것은 어떨까요?
leebs0521
reviewed
Nov 26, 2024
| private void validateWriter(CommunityBoard communityBoard, UUID writerId) { | ||
| if (communityBoard.getWriterId().equals(writerId)) { | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
communityBoard.getWriterId().equals(writerId)
이 부분은 CommunityBoard 메서드 호출해서 하는거 어떻게 생각하세요??
communityBoard.isWriter(writerId); 이런식으로요
Collaborator
Author
There was a problem hiding this comment.
TDA 감사합니다
수정하겠습니다!
- findById 메서드로 추출(추상화 레벨 일관성) - ServiceTest 중복되는 부분 @beforeeach로 추출 - CommunityBoard 메서드에 isWriter 추가
|
7zrv
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
커뮤니티 게시글 삭제 기능
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점