Feature/56 커뮤니티 게시글 수정 기능 #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
leebs0521
approved these changes
Nov 27, 2024
|
|
||
| //when | ||
| ThrowableAssert.ThrowingCallable callable = () -> updateCommunityBoardService.updateCommunityBoard(dto, communityId, UUID.randomUUID(), null); | ||
|
|
Collaborator
There was a problem hiding this comment.
ThrowingCallable 이거 좋은것 같아요.
when 에서 에러가 발생하는 동작을 이렇게 뺄수있군요..
src/test/java/com/somemore/community/service/command/UpdateCommunityBoardServiceTest.java
Show resolved
Hide resolved
Collaborator
|
"해당 게시글에 권한이 없습니다. " 라는 표현이 |
7zrv
approved these changes
Nov 27, 2024
- command/query 패키지 삭제
|
m-a-king
reviewed
Nov 27, 2024
Comment on lines
+13
to
14
| UNAUTHORIZED_COMMUNITY_BOARD("해당 게시글에 권한이 없습니다."), | ||
| NOT_EXISTS_LOCATION("존재하지 않는 위치 ID 입니다."), |
Collaborator
There was a problem hiding this comment.
Suggested change
| UNAUTHORIZED_COMMUNITY_BOARD("해당 게시글에 권한이 없습니다."), | |
| NOT_EXISTS_LOCATION("존재하지 않는 위치 ID 입니다."), | |
| NOT_FOUND("%s를 찾을 수 없습니다."), | |
| UNAUTHORIZED("%s에 대한 권한이 없습니다."), |
이렇게 사용하고 아래에서 메시지 게터에 도메인이나 맥락에 대해서 동적으로 파라미터를 사용하는 방법은 어떨까요?
Collaborator
Author
There was a problem hiding this comment.
다 같이 얘기해보면 좋을 거 같아요!
src/test/java/com/somemore/community/service/command/UpdateCommunityBoardServiceTest.java
Show resolved
Hide resolved
m-a-king
reviewed
Nov 27, 2024
Collaborator
m-a-king
left a comment
m-a-king
left a comment
There was a problem hiding this comment.
ExceptionMessage를 "해당 게시글에 권한이 없습니다."로 해두었는데
"자신이 작성한 커뮤니티 게시글이 아닙니다."로 통일하는게 좋을까요?
--> 후자는 프론트에서 하면 좋을 것 같아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
커뮤니티 게시글 수정 기능
👩💻 요구 사항과 구현 내용
커뮤니티 게시글 수정 기능 구현
✅ PR 포인트 & 궁금한 점
"자신이 작성한 커뮤니티 게시글이 아닙니다."로 통일하는게 좋을까요?