Feature/68 커뮤니티 댓글 삭제 기능 #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
7zrv
reviewed
Nov 28, 2024
| private final CommunityCommentRepository communityCommentRepository; | ||
|
|
||
| @Override | ||
| public void deleteCommunityComment(UUID writerId, Long id) { |
Collaborator
|
고생하셨습니다! |
7zrv
approved these changes
Nov 28, 2024
m-a-king
approved these changes
Nov 29, 2024
| @Override | ||
| public void deleteCommunityComment(UUID writerId, Long id) { | ||
|
|
||
| CommunityComment communityComment = getCommunityBoardById(id); |
Collaborator
There was a problem hiding this comment.
Suggested change
| CommunityComment communityComment = getCommunityBoardById(id); | |
| CommunityComment communityComment = getCommunityCommentById(id); |
이게 맞겠죠?
Collaborator
Author
There was a problem hiding this comment.
와 감사합니다
수정했습니다!
- getCommunityBoardById -> getCommunityCommentById
leebs0521
reviewed
Nov 29, 2024
| } | ||
|
|
||
| private CommunityComment getCommunityBoardById(Long id) { | ||
| return communityCommentRepository.findById(id) |
Collaborator
There was a problem hiding this comment.
이것도 getCommunityCommentById() 인 것 같아여
Collaborator
Author
There was a problem hiding this comment.
넵 제가 실수했어요..
수정했습니다!
|
leebs0521
pushed a commit
that referenced
this pull request
Nov 29, 2024
* test(community): CommunityComment 삭제 기능 테스트 작성 * test(community): CommunityComment 삭제 Usecase 추가 및 Service 구현 * test(community): CommunityComment 작성자 확인 메서드 및 권한 예외 메세지 추가 * refactor(community): 코드 리뷰 사항 반영 - getCommunityBoardById -> getCommunityCommentById
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
커뮤니티 댓글 삭제 기능
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점