Feature/6 ci docker integration #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DockerFile ์ถ๊ฐ์ ์ด๊ธฐ ์คํ๊ฐ ์ค์
- CI workflow์ ๋์ปค ๋น๋์ Push ๋ช ๋ น ์ถ๊ฐ - ๋น๋ ํ ์คํธ ์งํํ ํต๊ณผ๋๋ค๋ฉด ์ด๋ฏธ์ง๋ฅผ ๋์ปคํ๋ธ์ ์ถ๊ฐ
- ๊ธฐ์กด DockerFile๋ก ์ค๊ฐ์ F ๋๋ฌธ์๋ก ์ธํด ์๋ฌ๊ฐ ๋ฐ์ํ์ฌ ํ์ผ๋ช ์ ์์ ํจ
- ๋ธ๋์น ์์ฑ์ค ๋๋ฝ๋ workflow์ Sonar ๊ด๋ จ job ์ถ๊ฐ
leebs0521
approved these changes
Nov 19, 2024
Collaborator
leebs0521
left a comment
leebs0521
left a comment
There was a problem hiding this comment.
๊ณ ์ํ์ จ์ต๋๋ค
m-a-king
reviewed
Nov 19, 2024
Collaborator
m-a-king
left a comment
m-a-king
left a comment
There was a problem hiding this comment.
์๊ณ ํ์ จ์ต๋๋ค!
.github/workflows/CI.yml
Outdated
| - name: Build and analyze | ||
| - name: Docker build and push | ||
| run: | | ||
| echo "${{ secrets.DOCKER_HUB_PASSWORD }}" | docker login -u "${{ secrets.DOCKER_HUB_USERNAME }}" --password-stdin |
Collaborator
There was a problem hiding this comment.
Suggested change
| echo "${{ secrets.DOCKER_HUB_PASSWORD }}" | docker login -u "${{ secrets.DOCKER_HUB_USERNAME }}" --password-stdin | |
| - name: Login to Docker Hub | |
| run: docker login -u ${{ secrets.DOCKER_USERNAME }} -p ${{ secrets.DOCKER_ACCESS_TOKEN }} |
๋ก๊ทธ์ธ์ ๋ฐ๋ก ๋นผ๋ฉด ๊ฐ๊ฒฐํด์ง ๊ฒ ๊ฐ์์
Collaborator
Author
There was a problem hiding this comment.
๋ฐ๋ก ๋ถ๋ฆฌํ ์๊ฐ์ ๋ชปํ์๋ค์ ๊ฐ์ฌํฉ๋๋ค ๋ฐ์ํ๊ฒ ์ต๋๋ค
Comment on lines
+88
to
+89
| docker push 7zrv/somemore:${GITHUB_SHA::7} | ||
| docker push 7zrv/somemore:latest |
Collaborator
There was a problem hiding this comment.
๋ฒ์ ๊ด๋ฆฌ์ ์ข์ ์์ ๊ฐ์ต๋๋ค
ayoung-dev
approved these changes
Nov 19, 2024
Collaborator
ayoung-dev
left a comment
ayoung-dev
left a comment
There was a problem hiding this comment.
๊ณ ์ํ์ จ์ต๋๋ค~
- ๋ณด์๊ฐํ๋ฅผ ์ํด CI workflow์์์ ๋์ปค ๋ก๊ทธ์ธ ๋ฐฉ์์ ๊ธฐ์กด ํจ์ค์๋ ๋ฐฉ์์์ ์์ธ์ค ํ ํฐ ๋ฐฉ์์ผ๋ก ๋ณ๊ฒฝ
- ๋ณด์๊ฐํ๋ฅผ ์ํด CI workflow์์์ ๋์ปค ๋ก๊ทธ์ธ ๋ฐฉ์์ ๊ธฐ์กด ํจ์ค์๋ ๋ฐฉ์์์ ์์ธ์ค ํ ํฐ ๋ฐฉ์์ผ๋ก ๋ณ๊ฒฝ
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved : #6
๐ ๊ณผ์ ์ค๋ช
ํ๋ก์ ํธ์ ๋์ปค ์ด๋ฏธ์ง ์์ฑ๊ณผ ๋์ปค ํ๋ธ์ Pushํ๋ ๊ณผ์ ์ ์๋ํ ์ํค๋ ์์ ์ ๋๋ค.
๐ฉโ๐ป ์๊ตฌ ์ฌํญ๊ณผ ๊ตฌํ ๋ด์ฉ
RQ-038
โ PR ํฌ์ธํธ & ๊ถ๊ธํ ์