fix: aria-label 수정 #164
Merged
fix: aria-label 수정 #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
wldnjs990
approved these changes
Mar 19, 2025
Collaborator
wldnjs990
left a comment
wldnjs990
left a comment
There was a problem hiding this comment.
덕분에 라이트하우스 점수 더 올라갈거 같습니다
고생하셨습니다!!!👍👍👍👍👍👍👍👍👍👍
Collaborator
Author
확인해보니 접근성이 82 ➡️ 90으로 올라갔네용! 🙏🏻 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 요약
aria-label수정🪄 변경사항
aria-label추가aria-label수정aria-label삭제버튼의 텍스트가 이미 기능을 명확하게 설명할 때에는 스크린 리더가 그 텍스트를 읽어주므로
aria-label을 추가하는 것은 불필요합니다. 중복된 정보를 제공하면 스크린 리더 사용자가 버튼의 기능을 두 번 읽을 수 있어 혼란을 줄 수 있습니다 🥲반면에
aria-label을 추가하여 버튼의 기능을 명확히 설명하는 것이 적절합니다!🖼️ 결과 화면 (선택)
💬 리뷰어에게 전할 말 (선택)
aria-label관해서 자주 말씀 드렸는데 위 내용 확인해보시는 게 좋을 것 같습니다!