Skip to content

perf: 홈 페이지 접근성 향상 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged

perf: 홈 페이지 접근성 향상 #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c01350f
perf: 메뉴 버튼에서 div를 button으로 변경
tifsy Mar 21, 2025
c17c11b
perf: 홈 페이지 header에서 마이페이지로 이동하는 link에 aria-label 추가
tifsy Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/MenuButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export default function MenuButton() {
<EditNoteRoundedIcon fontSize="medium" />
</Link>

<div
<button
className={twMerge(
'bg-primary-3 fixed bottom-[30px] z-30 flex h-13 w-13 content-center items-center justify-center rounded-full text-white transition-all duration-200 hover:scale-105 active:scale-90',
isOpen ? 'rotate-90' : 'rotate-0',
Expand All @@ -62,7 +62,7 @@ export default function MenuButton() {
aria-label="메뉴 열기"
>
<MenuRoundedIcon />
</div>
</button>
</div>
</>
);
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Home/components/HomeHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const HomeHeader = () => {
<FlareRoundedIcon className="h-6 w-6 text-white" onClick={toggleTheme} />
)}
<NotificationButton />
<Link to="/mypage">
<Link to="/mypage" aria-label="마이페이지로 이동">
<PersonIcon className="h-6 w-6 text-white" />
</Link>
</div>
Expand Down