-
Notifications
You must be signed in to change notification settings - Fork 2
feat: 임시저장된 편지 삭제 기능 구현 #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8bbfb04
fix: 공유 게시글 목록 페이지네이션에서 무한 스크롤로 전환
tifsy 35e53a0
Merge remote-tracking branch 'origin/develop' into 74-delete-draft-le…
tifsy 44d2bac
refactor: 필요없는 코드 삭제
tifsy 176b64e
feat: 임시저장된 편지 삭제 기능 구현
tifsy 2244291
design: 임시저장 편지 삭제 아이콘 클릭 시 색상 변경
tifsy 8ada549
Merge branch 'develop' into 74-delete-draft-letters
tifsy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ import DeleteOutlineRoundedIcon from '@mui/icons-material/DeleteOutlineRounded'; | |
| import React, { useEffect, useState } from 'react'; | ||
| // import { useNavigate } from 'react-router'; | ||
|
|
||
| import { DraftLetter, getDraftLetters } from '@/apis/draftLetters'; | ||
| import { DraftLetter, getDraftLetters, deleteDraftLetters } from '@/apis/draftLetters'; | ||
| import ModalBackgroundWrapper from '@/components/ModalBackgroundWrapper'; | ||
| import ModalOverlay from '@/components/ModalOverlay'; | ||
|
|
||
|
|
@@ -22,14 +22,29 @@ const ShowDraftModal = ({ onClose }: ShowDraftModalProps) => { | |
| // }); | ||
| // }; | ||
|
|
||
| useEffect(() => { | ||
| const handleGetDraftLetters = () => { | ||
| getDraftLetters() | ||
| .then((data) => { | ||
| setDraftLetters(data || []); | ||
| }) | ||
| .catch((error) => { | ||
| console.error('❌ 임시저장된 편지를 불러오는데 실패했습니다', error); | ||
| }); | ||
| }; | ||
|
|
||
| const handleDeleteDraftLetters = async (letterId: number) => { | ||
| //TODO: 정말로 삭제하시겠습니까? 모달창 | ||
| try { | ||
| await deleteDraftLetters(letterId); | ||
| setDraftLetters((prev) => prev.filter((letter) => letter.letterId !== letterId)); | ||
| console.log(`letterId는 `, letterId); | ||
| } catch (error) { | ||
| console.error(`❌임시저장된 편지를 삭제하던 중 에러가 발생했습니다.`, error); | ||
| } | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| handleGetDraftLetters(); | ||
| }, [onClose]); | ||
|
|
||
| return ( | ||
|
|
@@ -52,7 +67,11 @@ const ShowDraftModal = ({ onClose }: ShowDraftModalProps) => { | |
| // onClick={() => handleNavigation(draft.letterId)} | ||
| > | ||
| <p className="truncate">{draft.title}</p> | ||
| <div className="text-gray-20"> | ||
| <div | ||
| className="text-gray-20 active:text-gray-600" | ||
| tabIndex={0} | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 요 탭인덱스는 뭔가용??
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| onClick={() => handleDeleteDraftLetters(draft.letterId)} | ||
| > | ||
| <DeleteOutlineRoundedIcon /> | ||
| </div> | ||
| </div> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생각해보니 저도 api 타입 넣는거 깜빡하고 있었네요..! 천천히 리팩토링 하겠습니다!!!