[refactor] 개인 메세지 구현 #112
Merged
[refactor] 개인 메세지 구현 #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # backend/src/main/java/io/f1/backend/domain/auth/dto/CurrentUserAndAdminResponse.java # backend/src/main/java/io/f1/backend/domain/game/app/RoomService.java # backend/src/main/java/io/f1/backend/domain/game/dto/MessageType.java # backend/src/main/java/io/f1/backend/domain/game/mapper/RoomMapper.java # backend/src/main/java/io/f1/backend/domain/game/model/Room.java # backend/src/main/java/io/f1/backend/global/config/WebSocketConfig.java
# Conflicts: # backend/src/main/java/io/f1/backend/domain/game/app/RoomService.java # backend/src/main/java/io/f1/backend/domain/game/dto/response/ExitSuccessResponse.java
jiwon1217
reviewed
Jul 23, 2025
| "/signup", | ||
| "/css/**", | ||
| "/js/**", | ||
| "/**", |
Collaborator
There was a problem hiding this comment.
이 url path를 추가하면 요청 전체가 permitAll로 설정됩니다 수정 부탁드립니다 !
Collaborator
Author
There was a problem hiding this comment.
재연결 pr이랑 마구마구섞였더니 .. 이런 실수를.. 감사합니다!!
dlsrks1021
reviewed
Jul 23, 2025
backend/src/main/java/io/f1/backend/domain/game/app/RoomService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/io/f1/backend/domain/game/dto/response/ExitSuccessResponse.java
Outdated
Show resolved
Hide resolved
# Conflicts: # backend/src/main/java/io/f1/backend/domain/game/app/RoomService.java
dlsrks1021
reviewed
Jul 25, 2025
backend/src/main/java/io/f1/backend/domain/game/dto/SystemNoticeMessage.java
Outdated
Show resolved
Hide resolved
dlsrks1021
approved these changes
Jul 25, 2025
silver-eunjoo
approved these changes
Jul 25, 2025
Collaborator
silver-eunjoo
left a comment
silver-eunjoo
left a comment
There was a problem hiding this comment.
와..! 정말 신기한 기능입니다. 재연결 시 다음 라운드부터 참가할 수 있도록 한 것도 좋은 것 같습니다 !!
# Conflicts: # backend/src/main/resources/application.yml
# Conflicts: # backend/src/main/java/io/f1/backend/domain/game/app/GameService.java # backend/src/main/java/io/f1/backend/domain/game/app/RoomService.java # backend/src/main/java/io/f1/backend/domain/game/app/TimerService.java # backend/src/main/java/io/f1/backend/domain/game/dto/MessageType.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛰️ Issue Number
🪐 작업 내용
reconnect,exit,gameSetting등 브로드캐스트가 필요 없는 상황에서 불필요한 네트워크를 줄이기 위해convertAndSendToUser()를 사용MessageSender안에sendPersonal ()로 구현console에 개인메세지로 응답이 오는걸 확인했습니다.변경 목록
gameSetting브로드캐스팅 -> 개인 메세지systemNotice제외 모든 응답은 개인 메세지MessageSend.send를sendBroadcast로 메소드명 변경📚 Reference
✅ Check List