Skip to content

[refactor] 퀴즈, 문제 수정 API 리팩토링 #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 28, 2025
Merged

[refactor] 퀴즈, 문제 수정 API 리팩토링 #146

merged 10 commits into from
Jul 28, 2025

Conversation

@silver-eunjoo
Copy link
Collaborator

@silver-eunjoo silver-eunjoo commented Jul 28, 2025

🛰️ Issue Number

🪐 작업 내용

  1. 퀴즈와 문제가 하나의 API로 수정될 수 있도록 수정했습니다.
  2. request에는 기존에 저장된 값 + 바뀐 값 모든 필드의 값들이 전달되어 옵니다.
  • 그래서 기존 메서드에서 유효성 검사를 하는 것에서 DTO에 @Valid 검사로 변경했습니다.
  1. 썸네일은 프론트에서 변경감지로 변경되었을 때만 보내주도록 합니다.
  2. 이외의 퀴즈 정보, 문제, 답은 프론트에서 따로 변경감지 하지 않고, 백에서 업데이트합니다.

📚 Reference

✅ Check List

  • 코드가 정상적으로 컴파일되나요?
  • 테스트 코드를 통과했나요?
  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

@silver-eunjoo silver-eunjoo self-assigned this Jul 28, 2025
@silver-eunjoo silver-eunjoo added the refactoring 코드 리팩토링 label Jul 28, 2025
@silver-eunjoo silver-eunjoo linked an issue Jul 28, 2025 that may be closed by this pull request
[refactor] 퀴즈 수정 API 리팩토링 #142
Closed
1 task
jiwon1217
jiwon1217 approved these changes Jul 28, 2025
View reviewed changes
Copy link
Collaborator

@jiwon1217 jiwon1217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !

sehee123
sehee123 approved these changes Jul 28, 2025
View reviewed changes
Copy link
Collaborator

@sehee123 sehee123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리팩토링 뚝딱 . .. 멋지십니당.!

@silver-eunjoo silver-eunjoo merged commit 272a33d into dev Jul 28, 2025
2 checks passed
@silver-eunjoo silver-eunjoo deleted the refactor/142 branch July 28, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlsrks1021 dlsrks1021 dlsrks1021 approved these changes

@jiwon1217 jiwon1217 jiwon1217 approved these changes

@sehee123 sehee123 sehee123 approved these changes

Assignees

@silver-eunjoo silver-eunjoo

Labels

refactoring 코드 리팩토링

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[refactor] 퀴즈 수정 API 리팩토링

5 participants

@silver-eunjoo @dlsrks1021 @jiwon1217 @sehee123