-
Notifications
You must be signed in to change notification settings - Fork 3
[feat] 게임 방 전체 목록 조회 api 구현 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- RoomResponse 추가
backend/src/main/java/io/f1/backend/domain/game/dto/response/RoomResponse.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/io/f1/backend/domain/game/app/RoomService.java
Outdated
Show resolved
Hide resolved
- RoomService의 RoomMapper를 static import로 변경 - roomResponse DTO의 title을 roomName으로 변경
sehee123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 🧑💻
silver-eunjoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 !
jiwon1217
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 !
| } | ||
|
|
||
| // todo quizService에서 퀴즈 조회 메서드로 변경 | ||
| public RoomListResponse getAllRooms() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[L4-변경제안]
transactional readonly를 명시하면 좋다고 생각합니다 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
인메모리 리포지토리라 트랜잭션이 실질적으로 동작하진 않지만, 의도 전달 목적으로 명시하는 걸 말씀하시는 걸까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 인메모리 레포지토리란걸 잊고 있었네요. 수정 없이 이대로 하시면 될 것 같습니다 !
🛰️ Issue Number
Closes #14
🪐 작업 내용
📚 Reference
✅ Check List