[feat] 방 입장 및 validation 체크 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # backend/src/main/java/io/f1/backend/domain/game/api/RoomController.java # backend/src/main/java/io/f1/backend/domain/game/app/RoomService.java # backend/src/main/java/io/f1/backend/domain/game/mapper/RoomMapper.java # backend/src/main/java/io/f1/backend/domain/game/store/RoomRepository.java # backend/src/main/java/io/f1/backend/domain/game/store/RoomRepositoryImpl.java
Closed
4 tasks
dlsrks1021
reviewed
Jul 14, 2025
backend/src/main/java/io/f1/backend/domain/game/app/RoomService.java
Outdated
Show resolved
Hide resolved
# Conflicts: # backend/src/main/java/io/f1/backend/domain/game/api/RoomController.java # backend/src/main/java/io/f1/backend/domain/game/app/RoomService.java # backend/src/main/java/io/f1/backend/domain/game/dto/response/RoomValidationResponse.java
| @AllArgsConstructor | ||
| public class DefaultWebSocketResponse<T> implements WebSocketDto<T> { | ||
| private final MessageType type; | ||
| private final T message; |
Collaborator
There was a problem hiding this comment.
바로 WebSocketDto를 클래스로 사용하지 않고, 이를 implement 하는 식으로 구현한 이유가 궁금합니다 ! 추후에 확장 가능성이 있는 건가요?
Collaborator
Author
There was a problem hiding this comment.
우선은 WebSocket으로 주고받는 응답은 반드시 type과 message라는 구조를 가져야 한다는 의도를 명확히 하기 위해서 인터페이스로 분리했습니다.
추후에 확장 가능성을 생각할 때도 interface로 강제해두면 이후 응답 형태가 늘어나도 일관된 구조를 유지할 수 있다는 점에서 인터페이스를 설계하였습니다!
Collaborator
There was a problem hiding this comment.
옹 ! 이해했습니다. 답변 감사합니다 ! :)
no content로 응답 변경으로 인한 응답 dto 삭제
silver-eunjoo
approved these changes
Jul 14, 2025
Collaborator
silver-eunjoo
left a comment
silver-eunjoo
left a comment
There was a problem hiding this comment.
굉장한 코드입니다... 고생하셨습니다 ! :)
dlsrks1021
approved these changes
Jul 14, 2025
jiwon1217
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛰️ Issue Number
close #6
🪐 작업 내용
흐름
입장 버튼 클릭 시
validation 체크
enter 로직 생성 (입장 요청 시 실행되는 흐름 )
웹소켓 연결
웹소켓 dto interface 생성
📚 Reference
https://docs.spring.io/spring-framework/reference/web/websocket/stomp/interceptors.html
https://github.com/spring-guides/gs-messaging-stomp-websocket/blob/main/complete/src/main/resources/static/app.js
✅ Check List