-
Notifications
You must be signed in to change notification settings - Fork 3
[feat] 방 입/퇴장 동시성 구현 및 로직 변경 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
41864be
:recycle: 소켓 연결 전 validation 체크 + enter 로직으로 변경
sehee123 f1b1308
:recycle: NPE 수정
sehee123 9157f7c
:sparkles: 동시성 추가 및 테스트
sehee123 0f52704
Merge remote-tracking branch 'origin/dev' into feat/20
sehee123 754a82b
chore: Java 스타일 수정
3fe0628
:recycle: 리뷰 반영(메소드 분리)
sehee123 39738fc
:sparkles: 방장은 입장 시 ready=true
sehee123 cae5121
:recycle: test 중복 코드 정리
sehee123 4ffea60
Merge remote-tracking branch 'origin/feat/20' into feat/20
sehee123 cfc104a
chore: Java 스타일 수정
ed66c38
:recycle: test code 빌더 수정
sehee123 54b8458
Merge remote-tracking branch 'origin/feat/20' into feat/20
sehee123 6624b79
chore: Java 스타일 수정
2e8cbbc
:recycle: 컨트롤러 이름 통일
sehee123 a669fb9
Merge remote-tracking branch 'origin/feat/20' into feat/20
sehee123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[L4-변경제안]
입장과 validation 검사를 한 번에 해주는 건데, 뭔가 컨트롤러는 메서드 네이밍이
validateRoom으로 남아있고, 다른 엔드포인트나 서비스 네이밍은enterRoom이라 컨트롤러 네이밍도enterRoom이면 좋겠다는 의견입니다 !There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉. 메소드 네임은 안바꾸고 경로만 바꿨네요 .. 메서드 네임 변경해서 puh했습니다. 감사합니다!