[feat] 플레이어 준비 상태 변경 기능 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LimKangHyun
requested review from
dlsrks1021,
jiwon1217,
sehee123 and
silver-eunjoo
Closed
sehee123
reviewed
Jul 16, 2025
| @MessageMapping("/room/ready/{roomId}") | ||
| public void playerReady(@DestinationVariable Long roomId, Message<?> message) { | ||
| StompHeaderAccessor accessor = StompHeaderAccessor.wrap(message); | ||
| String sessionId = accessor.getSessionId(); |
Collaborator
There was a problem hiding this comment.
이부분 바로 밑에 getSessionId() 로 대체하시면 될 것 같습니다!
sehee123
reviewed
Jul 16, 2025
| Player player = roomService.findPlayerInRoomBySessionId(sessionId, roomId); | ||
|
|
||
| player.toggleReady(); | ||
|
|
Collaborator
There was a problem hiding this comment.
이런 로직들은 컨트롤러보다 서비스에서 하는게 더 적합하지 않을까요 ?.? 🤔
Collaborator
Author
There was a problem hiding this comment.
세상에 서비스에 findPlayerInRoomBySessionId이 메서드만 만들어놓고 컨트롤러에서 다 하고있었네요 바로 수정하겠습니다. 감사합니다!
dlsrks1021
approved these changes
Jul 17, 2025
jiwon1217
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛰️ Issue Number
Closes #50
🪐 작업 내용
/room/ready/{roomId}으로 메시지를 SEND할 때마다 사용자의 isReady상태가 토글되고, 해당 방의 구독자들에게 브로드캐스팅 됩니다.📚 Reference
✅ Check List