[refactor] convertAndSend 계층 변경 #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
silver-eunjoo
approved these changes
Jul 18, 2025
Collaborator
silver-eunjoo
left a comment
silver-eunjoo
left a comment
There was a problem hiding this comment.
확인했습니다 ! 감사합니다 ! :)
LimKangHyun
approved these changes
Jul 18, 2025
Collaborator
LimKangHyun
left a comment
LimKangHyun
left a comment
There was a problem hiding this comment.
고생하셨습니다! 웹소켓의 마스터로 가는길... 험난하군요🧙♂️
dlsrks1021
reviewed
Jul 19, 2025
| messageSender.send( | ||
| destination, | ||
| MessageType.SYSTEM_NOTICE, | ||
| ofPlayerEvent(chatMessage.nickname(), RoomEventType.ENTER)); |
Collaborator
There was a problem hiding this comment.
[L3-중요질문]
플레이어가 보낸 채팅이 정답이었을 경우에 RoomEventType.ENTER를 전송하는 것은 아직 정답에 대한 EventType이 정의되어 있지 않아서일까요?
Collaborator
Author
There was a problem hiding this comment.
넵 맞습니다. 현재 은주님이 추가해놓고 변경 후 작업중이신걸로 알고있습니다.
# Conflicts: # backend/src/main/java/io/f1/backend/domain/game/websocket/GameSocketController.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛰️ Issue Number
🪐 작업 내용
convertAndSend로 응답을 내려주는건 서비스 레이어 책임(메시지 발송이기때문에 SRP에 따라서 서비스가 담당)
data로 명명되었던DTO도 삭제gameStart부분 리팩토링 하시면GameSocketController에서todo로 표해둔messageSender와getDestination삭제 부탁드립니다!📚 Reference
✅ Check List