Skip to content

[refactor] 퀴즈 정보 조회 메서드 수정 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2025
Merged

[refactor] 퀴즈 정보 조회 메서드 수정 #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bd3f28
:recycle: refactor: saveRoom, 퀴즈 정보 조회 메서드 수정
LimKangHyun Jul 19, 2025
81a6e9c
chore: Java 스타일 수정
Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions backend/src/main/java/io/f1/backend/domain/game/app/RoomService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import io.f1.backend.domain.game.dto.response.RoomResponse;
import io.f1.backend.domain.game.dto.response.RoomSettingResponse;
import io.f1.backend.domain.game.dto.response.SystemNoticeResponse;
import io.f1.backend.domain.game.event.RoomCreatedEvent;
import io.f1.backend.domain.game.model.GameSetting;
import io.f1.backend.domain.game.model.Player;
import io.f1.backend.domain.game.model.Room;
Expand Down Expand Up @@ -67,7 +68,8 @@ public class RoomService {
public RoomCreateResponse saveRoom(RoomCreateRequest request) {

QuizMinData quizMinData = quizService.getQuizMinData();
// Quiz quiz = quizService.getQuizWithQuestionsById(quizMinId);

Quiz quiz = quizService.findQuizById(quizMinData.quizMinId());

GameSetting gameSetting = toGameSetting(quizMinData);

Expand All @@ -83,7 +85,7 @@ public RoomCreateResponse saveRoom(RoomCreateRequest request) {

roomRepository.saveRoom(room);

// eventPublisher.publishEvent(new RoomCreatedEvent(room, quiz));
eventPublisher.publishEvent(new RoomCreatedEvent(room, quiz));

return new RoomCreateResponse(newId);
}
Expand Down
7 changes: 7 additions & 0 deletions backend/src/main/java/io/f1/backend/domain/quiz/app/QuizService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,4 +261,11 @@ public List<Question> getRandomQuestionsWithoutAnswer(Long quizId, Integer round

return randomQuestions;
}

@Transactional(readOnly = true)
public Quiz findQuizById(Long quizId) {
return quizRepository
.findById(quizId)
.orElseThrow(() -> new CustomException(QuizErrorCode.QUIZ_NOT_FOUND));
}
}